Repository navigation
feat(core-models): model unsigned_abs for signed integers - #2347
Open
WilliamTakeshi wants to merge 1 commit into
Open
WilliamTakeshi wants to merge 1 commit into
WilliamTakeshi wants to merge 1 commit into
Conversation
WilliamTakeshi
force-pushed
the
add-core-models-unsigned-abs
branch
from
October 23, 2026 13:22
906d9ed to
b45adc2
Compare
WilliamTakeshi
force-pushed
the
add-core-models-unsigned-abs
branch
from
October 23, 2026 13:27
b45adc2 to
885c522
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add model for unsigned_abs
While working on proofs for lakers, I hit a call to
.unsigned_abs()that neither backend could resolve, because core-models had no model for it. The fix looked small, so I added it myself.Problem
extracts fine but fails to typecheck:
Tested again pointing to hax local, everything works.
Question for maintainers
I'd like to keep filling in missing core-models items as I run into them. Is that welcome, or is there ongoing work I should coordinate with or wait for?
Should I do one change per PR? because seems like the generated lean/F* code can create conflicts in some cases
Disclaimer
I used Claude Opus 5.5 to help me understand where was to update it, every line was reviewed by me