OCTO-11603 SCCReader positioning and SRTWriter spacing fixes - #433
Merged
Merged
Conversation
Judge mid-line PACs by distance from the cursor rather than from the line origin, and handle Tab Offsets and pending breaks around them. Fixes a doubled PAC dropping its Tab Offset, the extended-character backspace crossing rows or cues, and the italic-closing node taking the wrong position. SRTWriter no longer doubles spaces between text nodes or leaves trailing spaces on lines. Changelog entries are under 2.3.12. The 2.3.10 section is unchanged from main.
🟢 PR Compliance ReviewRisk Level: LOW
SAFE TO MERGE - No critical issues found Full report available in workflow artifacts |
🟡 PR Compliance ReviewRisk Level: MEDIUM
REVIEW REQUIRED - Address issues before merging Full report available in workflow artifacts |
OlteanuRares
changed the title
vpaul-dev
approved these changes
Sep 28, 2026
panasicov
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Judge mid-line PACs by distance from the cursor rather than from the line origin, and handle Tab Offsets and pending breaks around them. Fixes a doubled PAC dropping its Tab Offset, the extended-character backspace crossing rows or cues, and the italic-closing node taking the wrong position. SRTWriter no longer doubles spaces between text nodes or leaves trailing spaces on lines.
Changelog entries are under 2.3.12. The 2.3.10 section is unchanged from main.