fix(plugin-multi-tenant): avoid refreshing forms without stale tenant cookie - #18245
Merged
Merged
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
JarrodMFlesch
force-pushed
the
codex/fix-multi-tenant-form-refresh
branch
from
September 21, 2026 20:53
d1983ef to
c868191
Compare
paulpopus
approved these changes
Sep 22, 2026
JarrodMFlesch
added a commit
that referenced
this pull request
Sep 22, 2026
#18252) Identical to #18245, back-ported for 4.x. The tenant selection provider now skips `router.refresh()` on fresh tenant creation forms unless a stale tenant cookie exists. Under throttled network conditions, the unconditional refresh could replace the form after `name` and `domain` were filled, causing the create request to omit both required fields. Fixes the `Multi Tenant › Tenant Selector › should add tenant to the selector when creating a new tenant` test flakes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tenant selection provider now skips
router.refresh()on fresh tenant creation forms unless a stale tenant cookie exists. Under throttled network conditions, the unconditional refresh could replace the form afternameanddomainwere filled, causing the create request to omit both required fields.Fixes the
Multi Tenant › Tenant Selector › should add tenant to the selector when creating a new tenanttest flakes.