feat(Table): add composable sticky footer - #12645
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughAdds sticky footer support to ChangesSticky footer support
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds opt-in sticky table footers with a semantic footer component, documentation, and examples. Existing behavior remains unchanged by default, and no current merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant TableStickyFooter
participant InnerScrollContainer
participant Table
participant Tfoot
TableStickyFooter->>InnerScrollContainer: Render fixed-height scroll container
TableStickyFooter->>Table: Enable isStickyFooter
TableStickyFooter->>Tfoot: Render total row
Table->>Table: Apply stickyFooter modifier
Tfoot->>Tfoot: Render styled tfoot element
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What: Adds support for composable sticky table footers.
Jira: PF-3996
Tfootcomponent for semantic table footer rows.isStickyFooterprop toTable.Tfootfrom@patternfly/react-table.Tfootand sticky footer behavior.Validation:
yarn jest packages/react-table/src/components/Table/__tests__/Table.test.tsx packages/react-table/src/components/Table/__tests__/Tfoot.test.tsx --runInBandyarn tsc --build packages/tsconfig.json --pretty falseBoth checks passed.
Additional issues: None.
Summary by CodeRabbit
New Features
isStickyFooterproperty.Documentation