fix(LoginForm): expose username and password autocomplete - #12644
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. Walkthrough
ChangesLoginForm autocomplete support
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to LoginForm now supports separate username and password autocomplete values without changing default input behavior. The documented examples and regression coverage support the intended behavior, with no current merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What: Closes #12600
Adds optional
usernameAutoCompleteandpasswordAutoCompleteprops toLoginForm, allowing callers to set values such asusername,current-password, andnew-passwordon the individual inputs. Omitting the props preserves the existing behavior.Updates the basic login example and documents both props. Regression tests cover field-specific values, form-level autocomplete, and showing/hiding the password.
Validation:
yarn buildpassed.yarn lint:allpassed with existing warnings in unchanged files.Additional issues: None.
Summary by CodeRabbit
New Features
Documentation