feat(Drawer): Add full-size drawer - #12641
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe Drawer component adds the beta ChangesDrawer viewport support
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This adds beta viewport Drawer positioning and supports resizable drawers with optional content. The provided implementation, example, and regression coverage indicate no remaining merge-blocking risk. Sequence Diagram(s)sequenceDiagram
participant Page
participant Drawer
participant DrawerContext
participant DrawerPanelContent
participant DrawerElement
Page->>Drawer: renders with isViewport
Drawer->>DrawerContext: provides viewport state
Drawer->>DrawerElement: applies viewport modifier
DrawerPanelContent->>DrawerContext: reads viewport state and refs
DrawerPanelContent->>DrawerElement: measures selected sizing element
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Out of Scope Changes checkExplanation The Drawer implementation, documentation, example, and tests are in scope. The package metadata changes, especially the react-icons package and
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use isViewport and place drawer below Page to achieve a full-height drawer that allows Page content to scroll behind it. Fixes patternfly#12635
7a5801e to
605a877
Compare
Use isViewport and place drawer below Page to achieve a full-height drawer that allows Page content to scroll behind it.
Fixes #12635
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests