Skip to content

fix(gate): check_affected_readers.sh fails closed on grep error / missing dir (PMAT-6069) - #6091

Closed
noahgift wants to merge 1 commit into
gate/affected-set-readers-only-v6from
gate/affected-readers-failclosed-6069-v3
Closed

noahgift wants to merge 1 commit into
gate/affected-set-readers-only-v6from
gate/affected-readers-failclosed-6069-v3

Conversation

@noahgift

@noahgift noahgift commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Replaces #6084 (v2) and #6072 (linear rebuild: gate/affected-readers-failclosed-6069-v3 @ceb9196b57, one commit on gate/affected-set-readers-only-v6 @acb37a6605, PR #6090). Fixes #6069 (epic #5510). Stacked: base is the v6 branch, so the arm script refuses it until that base lands and this is retargeted to main. The earlier quorum flagged the || true as non-blocking; the check has no consumer yet. Must-fail rows: missing crates dir, grep rc 2 (shim). Mutant: making g() lenient turns the shim row red.

keep-open: #5510 epic
keep-open: #6072 is closed by wsweep as superseded.

🤖 Generated with Claude Code

keep-open: #6084 is closed by wsweep as superseded.

…a missing crates dir (#6069)

hits() and build_inputs() ended in `|| true`, so an unreadable or missing crates
dir, or any grep rc>=2, read as "no readers" and the check printed ok. A new g()
treats only rc 1 (no match) as empty; check() is RED on a missing dir and on a
failed scan. Self-test rows: missing dir and a grep shim exiting 2 must be RED,
a tree with no reader forms stays green; the shim row dies when g() is made lenient.

PMAT-Ticket: PMAT-6069
PMAT-Batch: BATCH-aprender-readers-6069
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift

Copy link
Copy Markdown
Member Author

Closed per operator ruling NOAH-0718Z R2 (aprender open PRs <=10): draft with no push for over 24h, over the cap. Branch kept; reopen when its ticket resumes. Survivors: #6223, #6341, #5793 and the ready PRs.

@noahgift noahgift closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant