Repository navigation
Handle null Form resources without losing inline measurements - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Form with a direct or indirect
/Resources nullcurrently turns the scan partial before its named-color inline images can be measured. Treat PDF null like an omitted entry after resolving the object, preserving the existing legacy resource fallback. Keep an explicitly empty dictionary empty.Bump the tool and package to 0.2.1 and document the limited compatibility behavior. PDF 32000-1 sections 7.3.7/7.3.9 define null-entry equivalence; section 7.8.3 describes the legacy inheritance construct as obsolete. This does not assert modern PDF conformance.
Validation: both null subcases fail on 0.2.0; absent and empty-dictionary controls pass. All 30 tests pass on Windows CPython 3.12.14 and 3.13.5, and against the installed wheel on 3.13.5. Wheel and sdist builds pass. An independent synthetic nested-Form CLI check passes for seven PDFs, including null/empty distinctions, resource overrides and context-dependent reuse. No historical corpus results or PDF bytes are changed.
Prepared and independently checked with OpenAI Codex assistance. This is a change to my own project, not external maintainer acceptance or adoption evidence.