Skip to content

check-versions: report untagged component changes - #2878

Merged
berendt merged 1 commit into
mainfrom
check-untagged
Nov 11, 2026
Merged

berendt merged 1 commit into
mainfrom
check-untagged

Conversation

@ideaship

@ideaship ideaship commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

A change merged on the default branch of a component repository is not part of a release until that repository is tagged. Renovate only updates a pin to a published tag, and check-versions.sh only compares the pins with the newest published versions, so untagged changes pass every check and are silently left out of a release.

check-versions.sh now compares the newest tag of every component repository with its default branch (GitHub compare API) and fails on untagged changes:

  • Repositories: those of etc/changelog-repositories.yml, i.e. components and the derived ones pinned in a requirements file. A component that is no longer released (kolla-operations, retired with OpenStack 2025.1) is not listed there and not checked. The repositories of the images built from the release tags are skipped, since the release process tags them itself.
  • Changes that do not reach a release do not count: CHANGELOG.md, dotfiles such as .github/ and .zuul.yaml, tox.ini, renovate.json, Pipfile/Pipfile.lock, molecule/, test/, tests/.

Changes can be left out of a release on purpose, and a minor release does not adopt a newer default Ceph release. The repeatable --allow NAME option (pin, symlink or repository) accepts such rows; they are still listed. create-tags.sh passes --allow through, so an intended exception no longer needs --skip-check-versions, which switches off every check.

Example output against main today:

$ ./scripts/check-versions.sh --allow latest/ceph.yml
STATUS    WHERE                                 PIN               ...  NOTE
allowed   latest/ceph.yml                       symlink           ...  newest active Ceph release, ceph-umbrella.yml does not exist yet (allowed)
untagged  osism/ansible-collection-services     untagged changes  ...  changed: roles/frr/defaults/main.yml, ...
untagged  osism/defaults                        untagged changes  ...  changed: all/099-kolla.yml
...

The README documents the check and --allow, and links the Dependency Dashboard for triggering a Renovate run.

The matching step in the release guide:

🤖 Generated with Claude Code

A change merged on the default branch of a component repository is not
part of a release until the repository is tagged: Renovate only updates
a pin to a published tag, and check-versions.sh only compares the pins
with the newest published versions. Untagged changes therefore pass all
checks and are silently left out of a release.

check-versions.sh now compares the newest tag of every component
repository with its default branch through the GitHub compare API. The
repositories are those of etc/changelog-repositories.yml: the
"components" and the "derived" ones that are pinned in a requirements
file. A component that is no longer released, such as kolla-operations
(retired with OpenStack 2025.1), is not listed there and not checked.
The repositories of the images built from the release tags are skipped,
the release process tags them itself. Changes that do not reach a
release do not count: CHANGELOG.md, dotfiles such as .github/ and
.zuul.yaml, tox.ini, renovate.json, the Pipfile development environment,
molecule/ and tests. A repository with other changes is reported as
untagged and fails the check.

Since a release can leave changes out on purpose, and a minor release
does not adopt a newer default Ceph release, rows that are intentionally
not current can be accepted with the repeatable --allow option (a pin,
symlink or repository). Allowed rows are still listed. create-tags.sh
passes --allow through, so an intended exception no longer requires
--skip-check-versions, which switches off every check including the
ones that should still apply.

The README describes the new check, --allow, and links the Renovate
Dependency Dashboard for triggering a Renovate run.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Roger Luethi <luethi@osism.tech>
@ideaship
ideaship marked this pull request as ready for review November 11, 2026 14:59
@ideaship ideaship self-assigned this Nov 11, 2026
@ideaship
ideaship requested a review from berendt November 11, 2026 14:59
@berendt
berendt merged commit 9bce802 into main Nov 11, 2026
3 checks passed
@berendt
berendt deleted the check-untagged branch November 11, 2026 16:56
@github-project-automation github-project-automation Bot moved this from New to Done in Human Board Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants