Repository navigation
check-versions: report untagged component changes - #2878
Merged
Merged
Conversation
A change merged on the default branch of a component repository is not part of a release until the repository is tagged: Renovate only updates a pin to a published tag, and check-versions.sh only compares the pins with the newest published versions. Untagged changes therefore pass all checks and are silently left out of a release. check-versions.sh now compares the newest tag of every component repository with its default branch through the GitHub compare API. The repositories are those of etc/changelog-repositories.yml: the "components" and the "derived" ones that are pinned in a requirements file. A component that is no longer released, such as kolla-operations (retired with OpenStack 2025.1), is not listed there and not checked. The repositories of the images built from the release tags are skipped, the release process tags them itself. Changes that do not reach a release do not count: CHANGELOG.md, dotfiles such as .github/ and .zuul.yaml, tox.ini, renovate.json, the Pipfile development environment, molecule/ and tests. A repository with other changes is reported as untagged and fails the check. Since a release can leave changes out on purpose, and a minor release does not adopt a newer default Ceph release, rows that are intentionally not current can be accepted with the repeatable --allow option (a pin, symlink or repository). Allowed rows are still listed. create-tags.sh passes --allow through, so an intended exception no longer requires --skip-check-versions, which switches off every check including the ones that should still apply. The README describes the new check, --allow, and links the Renovate Dependency Dashboard for triggering a Renovate run. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change merged on the default branch of a component repository is not part of a release until that repository is tagged. Renovate only updates a pin to a published tag, and
check-versions.shonly compares the pins with the newest published versions, so untagged changes pass every check and are silently left out of a release.check-versions.shnow compares the newest tag of every component repository with its default branch (GitHub compare API) and fails on untagged changes:etc/changelog-repositories.yml, i.e.componentsand thederivedones pinned in a requirements file. A component that is no longer released (kolla-operations, retired with OpenStack 2025.1) is not listed there and not checked. The repositories of the images built from the release tags are skipped, since the release process tags them itself.CHANGELOG.md, dotfiles such as.github/and.zuul.yaml,tox.ini,renovate.json,Pipfile/Pipfile.lock,molecule/,test/,tests/.Changes can be left out of a release on purpose, and a minor release does not adopt a newer default Ceph release. The repeatable
--allow NAMEoption (pin, symlink or repository) accepts such rows; they are still listed.create-tags.shpasses--allowthrough, so an intended exception no longer needs--skip-check-versions, which switches off every check.Example output against
maintoday:The README documents the check and
--allow, and links the Dependency Dashboard for triggering a Renovate run.The matching step in the release guide:
🤖 Generated with Claude Code