Repository navigation
drift: allowlist ceilometer_prometheus_exporter - #2875
Merged
Merged
Conversation
osism/defaults defines enable_ceilometer_prometheus_exporter and ceilometer_prometheus_exporter_port in all/099-kolla.yml. They drive a kolla-ansible patch OSISM carries that lets ceilometer's polling agents serve their samples to Prometheus. Upstream kolla-ansible has no such flag at any supported release, so kolla_enablement_orphan reads it as a service removed upstream and asks for its removal. The flag is an OSISM invention with no upstream counterpart by design, the same case as common, chrony and openstack_exporter, so allowlist it. kolla_orphan_config derives its dead-service set from kolla_enablement_orphan, so the same entry also clears ceilometer_prometheus_exporter_port there. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable_ceilometer_prometheus_exporterandceilometer_prometheus_exporter_portin osism/defaultsall/099-kolla.ymlare OSISM-invented variables for the carried kolla-ansible patch that exports ceilometer's polled samples to Prometheus. Upstream kolla-ansible defines no such flag, sokolla_enablement_orphanreports it as a service removed upstream, andkolla_orphan_configreports the port with it. The periodicrelease-tox-driftjob has failed on these two findings since that defaults change merged.This adds one
kolla_enablement_orphanallowlist entry, the same handling ascommon,chronyandopenstack_exporter.kolla_orphan_configderives its dead-service set from that check, so the one entry clears both.Verified locally with
check-drift.py --group kolla --plugin kolla_enablement_orphan --plugin kolla_orphan_config:2 to act on, exit 10 to act on, exit 0🤖 Generated with Claude Code