Skip to content

network: drop the frr_loopback_interface step - #1144

Merged
berendt merged 1 commit into
mainfrom
network-frr-loopback-default
Nov 13, 2026
Merged

berendt merged 1 commit into
mainfrom
network-frr-loopback-default

Conversation

@ideaship

Copy link
Copy Markdown
Contributor

The network configuration guide tells readers to set frr_loopback_interface: loopback0, and shows it in the IPv6 fabric underlay example, because the frr role defaulted to dummy0. Since OSISM 11.0.3 the role defaults to loopback0, so a new deployment does not need the setting.

The guide now says the role defaults to loopback0 and that releases before OSISM 11.0.3 default to dummy0 and need the setting. The line is dropped from the example.

🤖 Generated with Claude Code

The dummy interface section told readers to set
frr_loopback_interface: loopback0, as in the IPv6 fabric underlay
example, because the frr role defaulted to dummy0 and FRR announces
the addresses of the interface this variable names.

That default changed with osism/ansible-collection-services#2185,
shipped in osism.services 0.20261111.0 (OSISM 11.0.3): the role now
defaults frr_loopback_interface to loopback0. On a new deployment the
setting is unnecessary, and the guide should not ask for it.

Say that the role defaults to loopback0, that releases before OSISM
11.0.3 default to dummy0, and that only those need the setting. Drop
the line from the IPv6 fabric underlay example.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Roger Luethi <luethi@osism.tech>
@github-actions

Copy link
Copy Markdown

✅⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ ACTION actionlint 5 0 0 0.06s
✅ JSON jsonlint 4 0 0 0.08s
✅ JSON prettier 4 0 0 0.2s
✅ JSON v8r 4 0 0 7.14s
✅ MARKDOWN markdownlint 184 0 0 1.74s
✅ MARKDOWN markdown-table-formatter 184 0 0 0.2s
✅ REPOSITORY betterleaks yes no no 0.43s
✅ REPOSITORY checkov yes no no 13.76s
✅ REPOSITORY git_diff yes no no 0.04s
✅ REPOSITORY secretlint yes no no 0.88s
✅ REPOSITORY trufflehog yes no no 2.12s
✅ SPELL codespell 194 0 0 0.27s
⚠️ SPELL lychee 194 6 0 20.53s
✅ YAML prettier 6 0 0 0.23s
✅ YAML v8r 6 0 0 4.39s
✅ YAML yamllint 6 0 0 0.31s

Detailed Issues

⚠️ SPELL / lychee - 6 errors
📝 Summary
---------------------
🔍 Total.........1309
🔗 Unique.........960
✅ Successful....1180
⏳ Timeouts.........3
🔀 Redirected.......9
👻 Excluded.......120
❓ Unknown..........0
🚫 Errors...........6
⛔ Unsupported......6

Errors in .claude/skills/security-advisory/reference/style.md
[ERROR] file://.claude/skills/guides/operations-guide/openstack/security-updates.md (at 189:3) | File not found. Check if file exists and path is correct

Errors in .claude/skills/security-advisory/SKILL.md
[400] https://cveawg.mitre.org/api/cve/ (at 16:18) | Rejected status code: 400 Bad Request
[404] https://raw.githubusercontent.com/osism/ (at 17:18) | Rejected status code: 404 Not Found
[400] https://registry.osism.tech/service/token (at 18:19) | Rejected status code: 400 Bad Request

Errors in docs/appendix/security/ossa-2026-034.md
[503] https://github.com/osism/container-images-kolla/commit/cefc3e01eb2a898e2587b8decc3df03bc9272ce1 (at 206:3) | Rejected status code: 503 Service Unavailable

Errors in docs/concepts/cluster-network.md
[TIMEOUT] https://stordis.com/basic-configuration-and-management-of-sonic-devices/ (at 196:3) | Request timed out
[TIMEOUT] https://stordis.com/bgp-unnumbered-in-enterprise-sonic/ (at 66:1) | Request timed out
[TIMEOUT] https://stordis.com/deploying-bgp-underlay-in-enterprise-sonic/ (at 197:3) | Request timed out

Errors in docs/guides/developer-guide/style-guide.md
[ERROR] https://wiki.openstack.org/wiki/GitCommitMessages (at 79:1) | Network unreachable. Check internet connection or VPN settings

Hint: Followed 9 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.2.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,SPELL_CODESPELL,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@ideaship
ideaship marked this pull request as ready for review November 13, 2026 16:16
@ideaship ideaship self-assigned this Nov 13, 2026
@ideaship
ideaship requested a review from berendt November 13, 2026 16:16
@berendt
berendt merged commit 6f4b50f into main Nov 13, 2026
6 checks passed
@berendt
berendt deleted the network-frr-loopback-default branch November 13, 2026 18:18
@github-project-automation github-project-automation Bot moved this from New to Done in Human Board Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants