Repository navigation
Conversation
Any file in the image definition format can be passed with --images. Add a short section showing it with a published third-party catalog, and a note that such definitions are not reviewed by OSISM. Signed-off-by: Kevin Allioli <kevin@stackops.ch>
jklare
reviewed
Nov 13, 2026
Comment on lines
+176
to
+178
|
|
||
| Third-party definitions are not reviewed by OSISM: check their source before using them. | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| Third-party definitions are not reviewed by OSISM: check their source before using them. | |
| :::warning | |
| Third-party definitions are not reviewed by OSISM: check their source before using them. | |
| ::: | |
Contributor
There was a problem hiding this comment.
I think we could make this a bit more visible by using the warning annotation here. It might even be worth to move this to the beginning of the section, before handing people the gun to shoot their own foot.
Contributor
|
Hey @kallioli, thanks for the contribution. I left a quick suggestion, but think this looks like a good addition. |
…e section Signed-off-by: Kevin Allioli <kevin@stackops.ch>
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Image Manager accepts any file in the image definition format with
--images, not only the definitions shipped in/etc/images. This adds a short section to the Image Manager guide showing that with a published third-party catalog, plus a note that such definitions are not reviewed by OSISM.The example uses openimages.cloud, which publishes signed, boot-tested qcow2 images and their definitions at https://images.openimages.cloud/osism/images.yml. That file validates against
etc/schema.yaml(yamale) and was checked withopenstack-image-manager --latest --dry-run(URL test passed, import skipped as expected).Happy to reword or drop the concrete example if you prefer to keep the section generic.