Skip to content

NO-ISSUE: Require E2E on osac-test-infra and code owners (step B) - #272

Merged
eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:test-infra-native-flow-b
Oct 17, 2026
Merged

eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:test-infra-native-flow-b

Conversation

@eliorerz

Copy link
Copy Markdown
Contributor

Step B of moving osac-test-infra pull requests to the native flow of osac (step A, 271,
is applied and 612 is merged): the full-install suites become required through the E2E
check written by the OSAC CI app (integration 4966101), a path listed in CODEOWNERS
needs approval from its owner team, ci-duty may bypass the review requirements as in
osac, and the merge queue waits up to 180 minutes for slow full-install runs.

Why now: with only CI and jira-reference required, a code pull request that CodeRabbit
approves is put in the merge queue and can merge before any suite has run (seen on the
canary pull request 615, which I took out of the queue). The docs-only canary (614) showed the
app writes E2E on this repository, so requiring it is safe.

Apply on merge (Terraform). After it, the code canary needs the suites to pass.

Second step of moving osac-test-infra pull requests to the native flow: the
full-install suites are required through the E2E check written by the OSAC CI
app (integration 4966101), changes to paths in CODEOWNERS need their owner
team, ci-duty may bypass the review requirements as in osac, and the merge
queue waits up to 180 minutes for slow full-install runs.

Apply after step A and after a canary pull request has run the suites for
real.

Signed-off-by: Elior Erez <eerez@redhat.com>
@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 32193508-a901-4aea-8865-bf32743f00df
📥 Commits

Reviewing files that changed from the base of the PR and between 62eefae and da20a80.

📒 Files selected for processing: 1
  • repositories.tf
+--------------------------------------------------+
| CORS error? I've seen worse relationship issues. |
+--------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@eliorerz
eliorerz merged commit 345ca33 into osac-project:main Oct 17, 2026
1 of 2 checks passed
@eliorerz
eliorerz deleted the test-infra-native-flow-b branch October 17, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant