Repository navigation
NO-ISSUE: Require E2E on osac-test-infra and code owners (step B) - #272
Merged
Merged
Conversation
Second step of moving osac-test-infra pull requests to the native flow: the full-install suites are required through the E2E check written by the OSAC CI app (integration 4966101), changes to paths in CODEOWNERS need their owner team, ci-duty may bypass the review requirements as in osac, and the merge queue waits up to 180 minutes for slow full-install runs. Apply after step A and after a canary pull request has run the suites for real. Signed-off-by: Elior Erez <eerez@redhat.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step B of moving osac-test-infra pull requests to the native flow of osac (step A, 271,
is applied and 612 is merged): the full-install suites become required through the E2E
check written by the OSAC CI app (integration 4966101), a path listed in CODEOWNERS
needs approval from its owner team, ci-duty may bypass the review requirements as in
osac, and the merge queue waits up to 180 minutes for slow full-install runs.
Why now: with only CI and jira-reference required, a code pull request that CodeRabbit
approves is put in the merge queue and can merge before any suite has run (seen on the
canary pull request 615, which I took out of the queue). The docs-only canary (614) showed the
app writes E2E on this repository, so requiring it is safe.
Apply on merge (Terraform). After it, the code canary needs the suites to pass.