Skip to content

NO-ISSUE: Require CI and jira-reference on osac-test-infra (step A) - #271

Merged
eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:test-infra-native-flow-a
Oct 17, 2026
Merged

eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:test-infra-native-flow-a

Conversation

@eliorerz

@eliorerz eliorerz commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Step A of moving osac-test-infra pull requests to the native flow of osac: one
approval (dismissed on push), allow "Update branch", and the required checks CI
and jira-reference replace e2e-vmaas-gate, e2e-bmaas-gate, e2e-caas-gate,
check-labels and pre-commit.

DO NOT merge on its own. Terraform applies on merge, and until osac-test-infra
produces the CI check every open pull request there would be blocked. Merge it
in the switch window together with osac-test-infra pull request 612 (which adds
ci.yml), in this order: this change, merge 612 with the ci-duty bypass, then
step B (adds the E2E check from the OSAC CI app, 4966101, and a longer queue
timeout), once the suites have run for real.

Changes

  • CI and repository policy: osac-test-infra will allow branch updates and require one native GitHub approval. A new commit dismisses the approval.
  • Required checks: The five existing checks—e2e-vmaas-gate, e2e-bmaas-gate, e2e-caas-gate, check-labels, and pre-commit—are replaced by CI and jira-reference.
  • Scope: No API, controller, database, authentication, deployment, test, or documentation changes are described.
  • Compatibility: This changes the merge requirements. The supplied objective notes that open pull requests may be blocked until osac-test-infra produces the CI check. It also says not to merge this change by itself and describes a staged rollout.

Risk classification

The risk label and its classification criteria cannot be established from the supplied information. The labeling instructions and criteria were not provided, so I cannot state which label was applied or assess whether the change narrowly missed another classification.

First step of moving osac-test-infra pull requests to the native flow that
osac uses: one approval that a push dismisses, and the required checks CI and
jira-reference. The old gates (e2e-*-gate, check-labels, pre-commit) are
replaced by the CI check of the new ci.yml.

Apply together with the osac-test-infra change that adds ci.yml, in the
switch window; the E2E check follows as step B.

Signed-off-by: Elior Erez <eerez@redhat.com>
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 4b5abefc-1c3f-45ac-98ee-655397b26ca4
📥 Commits

Reviewing files that changed from the base of the PR and between a7eec65 and 770f9bc.

📒 Files selected for processing: 1
  • repositories.tf

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review.

Walkthrough

The repo_osac_test_infra settings now allow branch updates, require one approval, dismiss stale reviews, and require the CI and jira-reference checks.

Changes

Repository Rules

Layer / File(s) Summary
Branch protection and required checks
repositories.tf
repo_osac_test_infra allows branch updates, requires one approval, and dismisses stale reviews. Its required checks change to CI and jira-reference, both associated with integration ID 15368.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested labels: risk:ask

Suggested reviewers: omer-vishlitzky

Merge Risk: ⚪ Minimal · up to 770f9

The new checks may temporarily block ordinary pull requests until their producers are added, but the configured bypass supports the planned rollout sequence. No unresolved merge-blocking risk remains if that sequence is followed.

Pre-merge checks: Passed 11
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: requiring the CI and jira-reference checks for osac-test-infra as step A.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets Passed The pull request changes only repositories.tf. The added Terraform comments, booleans, approval count, status-check names, and integration ID contain no API keys, tokens, passwords, private keys, cr…
No-Weak-Crypto Passed The pull request changes only repositories.tf and updates GitHub repository review and status-check settings for repo_osac_test_infra. The diff adds no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, cu…
No-Injection-Vectors Passed PASS. The pull request changes only Terraform repository settings and comments in repositories.tf. The added values are static booleans, an integer, and fixed status-check names. No SQL concatenatio…
Container-Privileges Passed PASS. The pull request changes only repositories.tf repository settings. The diff contains no container or Kubernetes manifest and introduces none of the checked settings: privileged, hostPID, `…
No-Sensitive-Data-In-Logs Passed The pull request changes only Terraform repository settings and comments. It adds no logging, output, or diagnostic code, and the changed content contains no passwords, tokens, API keys, PII, session …
Ai-Attribution Passed No AI tool use is mentioned in the pull request description or commit message. The only commit trailer is Signed-off-by: Elior Erez <eerez@redhat.com>. No AI-related Co-Authored-By, Assisted-by,…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: No-Hardcoded-Secrets

Explanation

The pull request changes only repositories.tf. The added Terraform comments, booleans, approval count, status-check names, and integration ID contain no API keys, tokens, passwords, private keys, credentials, embedded-credential URLs, or secret-shaped base64/hex literals.

Full details: No-Weak-Crypto

Explanation

The pull request changes only repositories.tf and updates GitHub repository review and status-check settings for repo_osac_test_infra. The diff adds no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, or secret/token comparisons.

Full details: No-Injection-Vectors

Explanation

PASS. The pull request changes only Terraform repository settings and comments in repositories.tf. The added values are static booleans, an integer, and fixed status-check names. No SQL concatenation, shell execution, dynamic evaluation, unsafe deserialization, unsafe YAML loading, or HTML injection is introduced.

Full details: Container-Privileges

Explanation

PASS. The pull request changes only repositories.tf repository settings. The diff contains no container or Kubernetes manifest and introduces none of the checked settings: privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root execution, or allowPrivilegeEscalation.

Full details: No-Sensitive-Data-In-Logs

Explanation

The pull request changes only Terraform repository settings and comments. It adds no logging, output, or diagnostic code, and the changed content contains no passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data exposed through logs.

Full details: Ai-Attribution

Explanation

No AI tool use is mentioned in the pull request description or commit message. The only commit trailer is Signed-off-by: Elior Erez &lt;eerez@redhat.com&gt;. No AI-related Co-Authored-By, Assisted-by, or Generated-by trailer is present.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@eliorerz
eliorerz marked this pull request as ready for review October 17, 2026 20:44
@eliorerz
eliorerz merged commit 62eefae into osac-project:main Oct 17, 2026
2 checks passed
@eliorerz
eliorerz deleted the test-infra-native-flow-a branch October 17, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant