Repository navigation
NO-ISSUE: Require CI and jira-reference on osac-test-infra (step A) - #271
Merged
Merged
Conversation
First step of moving osac-test-infra pull requests to the native flow that osac uses: one approval that a push dismisses, and the required checks CI and jira-reference. The old gates (e2e-*-gate, check-labels, pre-commit) are replaced by the CI check of the new ci.yml. Apply together with the osac-test-infra change that adds ci.yml, in the switch window; the E2E check follows as step B. Signed-off-by: Elior Erez <eerez@redhat.com>
eliorerz
marked this pull request as ready for review
October 17, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step A of moving osac-test-infra pull requests to the native flow of osac: one
approval (dismissed on push), allow "Update branch", and the required checks CI
and jira-reference replace e2e-vmaas-gate, e2e-bmaas-gate, e2e-caas-gate,
check-labels and pre-commit.
DO NOT merge on its own. Terraform applies on merge, and until osac-test-infra
produces the CI check every open pull request there would be blocked. Merge it
in the switch window together with osac-test-infra pull request 612 (which adds
ci.yml), in this order: this change, merge 612 with the ci-duty bypass, then
step B (adds the E2E check from the OSAC CI app, 4966101, and a longer queue
timeout), once the suites have run for real.
Changes
osac-test-infrawill allow branch updates and require one native GitHub approval. A new commit dismisses the approval.e2e-vmaas-gate,e2e-bmaas-gate,e2e-caas-gate,check-labels, andpre-commit—are replaced byCIandjira-reference.osac-test-infraproduces theCIcheck. It also says not to merge this change by itself and describes a staged rollout.Risk classification
The risk label and its classification criteria cannot be established from the supplied information. The labeling instructions and criteria were not provided, so I cannot state which label was applied or assess whether the change narrowly missed another classification.