Skip to content

NO-ISSUE: Require the E2E check from the OSAC CI app and code owner review on osac #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eliorerz merged 1 commit into from
Oct 17, 2026
Merged

NO-ISSUE: Require the E2E check from the OSAC CI app and code owner review on osac #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions repositories.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,18 @@ module "repo_osac" {
# Jira lifecycle and cherry-picks.
required_approvals = 1
dismiss_stale_reviews = true
# Two required checks, both posted by GitHub Actions: `CI` is the one job that adds up every cheap check that applies
# to the change (ci.yml; a part that does not apply is skipped inside it), and `jira-reference` says the title names a
# Jira issue or NO-ISSUE (the Prow-set label jira/valid-reference). The full-install E2E is required in a second step,
# once its workflows are on main.
# A path listed in CODEOWNERS needs approval from its owner team (today the CI definition under .github/; a team adds
# its own folders by a pull request to CODEOWNERS), and a path with no owner needs nobody in particular.
require_code_owner_reviews = true
# Three required checks. `CI` is the one job that adds up every cheap check that applies to the change (ci.yml; a part
# that does not apply is skipped inside it) and `jira-reference` says the title names a Jira issue or NO-ISSUE (the
# Prow-set label jira/valid-reference); both are posted by GitHub Actions. `E2E` is the full-install suites on a real
# cluster (e2e-pr.yml for a pull request, e2e-queue.yml for a merge queue entry). It is required from the OSAC CI
# app only (integration id 4966101, the app that writes it), so a workflow that is not that app cannot satisfy it.
required_status_checks = [
{ context = "CI", integration_id = 15368 },
{ context = "jira-reference", integration_id = 15368 },
{ context = "E2E", integration_id = 4966101 },
]
ruleset_bypass_team_ids = [
github_team.all["managers"].id,
Expand Down
Loading