Repository navigation
NO-ISSUE: Require CI, jira-reference and one native approval on osac - #263
Merged
Merged
Conversation
eliorerz
force-pushed
the
osac-native-ci-step-a
branch
from
October 16, 2026 14:46
56d18dd to
80b5430
Compare
Replaces the 26 required checks of osac, which no longer report once the pipeline moves to one CI workflow, with the two checks of the new pipeline: CI (one job that adds up every cheap check that applies to the change) and jira-reference (the title names a Jira issue or says NO-ISSUE). Approval is a native review, one approval, dismissed when a new commit is pushed, instead of the Prow lgtm and approved labels. This is step A of two and is merged in the same window as the osac pull request that introduces the new pipeline, immediately before it: merging it earlier would block every osac pull request, because the CI check does not exist on main until then. Step B adds the E2E check. Signed-off-by: Elior Erez <eerez@redhat.com>
eliorerz
force-pushed
the
osac-native-ci-step-a
branch
from
October 17, 2026 13:38
80b5430 to
d3e7d51
Compare
eliorerz
marked this pull request as ready for review
October 17, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, step A of two. Do not merge before the osac switch window: merge it immediately before osac#1613 (the pull request that introduces the new pipeline) and then merge step B. Merged earlier, it would block every osac pull request, because the CI check does not exist on osac main until #1613 merges.
What it changes for osac:
Prow stays only for the Jira reference, the Jira lifecycle and cherry-picks.
Rollback: revert this commit. The old checks come back, and osac#1613 would have to be reverted with it, because the old checks no longer report once it is merged.
Summary
osacrepository now requires the GitHub Actions checksCIandjira-reference. One native GitHub approval is required, and GitHub dismisses approvals after a new commit.main; the prior checks stop reporting after that pipeline merges. The full-install E2E check is deferred to a later step.Risk classification
The applied risk label and its classification criteria are not available in the supplied evidence. I cannot determine whether
risk:ship,risk:show, orrisk:askapplies, or identify a close alternative.