Repository navigation
Base the default error penalty on the scalar start value - #716
Open
hmgaudecker wants to merge 1 commit into
Open
hmgaudecker wants to merge 1 commit into
hmgaudecker wants to merge 1 commit into
Conversation
For least-squares and likelihood solvers the default penalty constant was built from the start criterion's residual or contribution vector, so it became an array: a least-squares penalty raised InvalidFunctionError and a likelihood penalty landed at the wrong level. The default now derives from the scalar start value for every aggregation level. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hs8mfXPYyEa24KaAp6BwCW
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #715.
With
error_handling="continue", the default error penalty was built fromstart_criterion.internal_value(solver_type). For least-squares and likelihood solvers that is a vector, so:InvalidFunctionErrorinstead of being penalized;The default constant is now computed from the scalar start value for every aggregation level. The new test checks that, without explicit
error_penaltyoptions, the likelihood and least-squares penalties equal the scalar penalty of the same start value. It fails on main for both.https://claude.ai/code/session_01Hs8mfXPYyEa24KaAp6BwCW