Skip to content

Add push state attributes to repository protocols [IFC-3313] - #1400

Draft
gmazoyer wants to merge 1 commit into
infrahub-developfrom
gma-20261006-ifc-3313
Draft

gmazoyer wants to merge 1 commit into
infrahub-developfrom
gma-20261006-ifc-3313

Conversation

@gmazoyer

@gmazoyer gmazoyer commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Why

Infrahub adds nine read-only attributes to CoreRepository. They store the state of the pushes that wait for the Git remote, so that a failed push shows on the repository.

protocols.py is generated from the Infrahub core schema. Without these lines, invoke backend.generate in the Infrahub repository leaves the file dirty and the validate-generated job fails.

What changed

  • The nine delivery_* attributes are added to CoreRepository and CoreRepositorySync.

Nothing else. invoke backend.generate in the Infrahub repository renders the file.

How to review

One commit on top of infrahub-develop (2ac1179), which already has the rewrite record attributes. The Infrahub companion PR points the submodule at this commit.


Summary by cubic

Adds nine read-only delivery_* attributes to the CoreRepository and CoreRepositorySync protocols, so repositories can hold the state of pushes waiting for the Git remote and a failed push shows on the repository. protocols.py is generated from the Infrahub core schema; these lines keep the generated file clean and the validate-generated job passing.

Written for commit 9d21dac. Summary will update on new commits.

View guided diff Turn on auto-fix

Relates to

Infrahub companion PR: opsmill/infrahub#10906

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d21dac
Status: ✅  Deploy successful!
Preview URL: https://3929f497.infrahub-sdk-python.pages.dev
Branch Preview URL: https://gma-20261006-ifc-3313.infrahub-sdk-python.pages.dev

View logs

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                 Coverage Diff                  @@
##           infrahub-develop    #1400      +/-   ##
====================================================
- Coverage             87.14%   86.81%   -0.33%     
====================================================
  Files                   153      152       -1     
  Lines                 16493    14761    -1732     
  Branches               2417     1982     -435     
====================================================
- Hits                  14372    12815    -1557     
+ Misses                 1493     1382     -111     
+ Partials                628      564      -64     
Flag Coverage Δ
integration-tests 42.40% <100.00%> (-1.21%) ⬇️
python-3.10 60.97% <100.00%> (-1.08%) ⬇️
python-3.11 60.97% <100.00%> (-1.08%) ⬇️
python-3.12 60.97% <100.00%> (-1.08%) ⬇️
python-3.13 60.97% <100.00%> (-1.08%) ⬇️
python-3.14 60.95% <100.00%> (-1.09%) ⬇️
python-filler-3.12 22.87% <0.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/protocols.py 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Infrahub adds nine read-only attributes to CoreRepository. They store
the state of the pushes that wait for the remote, so that a failed push
shows on the repository.

This file is generated from the Infrahub core schema. Without these
lines, invoke backend.generate in the Infrahub repository leaves the
file dirty and the validate-generated job fails.
@gmazoyer
gmazoyer force-pushed the gma-20261006-ifc-3313 branch from b37f299 to 0e9497a Compare October 7, 2026 13:23
@gmazoyer
gmazoyer changed the base branch from infrahub-develop to gma-20261006-ifc-3284 October 7, 2026 13:23
Base automatically changed from gma-20261006-ifc-3284 to infrahub-develop October 7, 2026 18:35
@gmazoyer
gmazoyer force-pushed the gma-20261006-ifc-3313 branch from 0e9497a to 9d21dac Compare October 7, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant