Repository navigation
feat(storage): Add replicated keyspace drop - #1643
Merged
Merged
Conversation
Add Mutation::DropKeyspace, committed through Raft and applied on
every node, and StorageApi::list_keyspaces(prefix) for cleanup
discovery (ADR 0044 step 3).
DropKeyspace is accepted only for names matching
single_use_{use_case}_{bucket} with a numeric bucket, and only in a
transaction made of drops. Apply runs after the batch commits and
removes the keyspace, its per-record metadata in the meta keyspace
and any ephemeral entry. A missing keyspace is a no-op.
The real storage reported the first violation of any type as
Conflict, so a rate limit, quarantine or refused drop looked like
a replay. Violations other than CONFLICT now surface as the new
StoreError::Rejected, which keeps the violation type.
Move require_no_conflict from the scim, service-grant and
oauth2-client drivers into storage-api. It maps only a CONFLICT
violation or error to the caller's conflict and returns Rejected for
any other violation. The oauth2-key JTI retry loop uses it and no
longer retries a rejected write.
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
enabled auto-merge
November 13, 2026 19:00
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
|
🧪 Tempest Identity Compatibility Results (advisory, non-blocking) rust Failed test IDs |
|
Bencher Report| Project | keystone |
| Branch | raft-single-use-storage |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 131,550.00 ns(+4.61%)Baseline: 125,748.58 ns | 206,265.13 ns (63.78%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 153,070.00 ns(+16.41%)Baseline: 131,487.23 ns | 201,357.98 ns (76.02%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 107.00 ns(-7.03%)Baseline: 115.10 ns | 165.07 ns (64.82%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 94.22 ns(-8.69%)Baseline: 103.19 ns | 144.72 ns (65.11%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 160.80 ns(-14.74%)Baseline: 188.60 ns | 274.41 ns (58.60%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 95.50 ns(-7.41%)Baseline: 103.15 ns | 144.62 ns (66.03%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 149.05 ns(+3.59%)Baseline: 143.89 ns | 215.91 ns (69.03%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 122.66 ns(+0.61%)Baseline: 121.91 ns | 181.25 ns (67.67%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 208.76 ns(-6.45%)Baseline: 223.16 ns | 340.62 ns (61.29%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 121.56 ns(+0.39%)Baseline: 121.09 ns | 178.13 ns (68.24%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 101.25 ns(-5.45%)Baseline: 107.09 ns | 159.45 ns (63.50%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 184.71 ns(-4.49%)Baseline: 193.40 ns | 295.85 ns (62.43%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 143.76 ns(-1.51%)Baseline: 145.96 ns | 216.94 ns (66.27%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 203.37 ns(-10.47%)Baseline: 227.15 ns | 346.88 ns (58.63%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 3,691,400.00 ns(+1.38%)Baseline: 3,641,239.22 ns | 7,759,280.23 ns (47.57%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 23,699.00 ns(-26.95%)Baseline: 32,441.62 ns | 50,099.89 ns (47.30%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 305,100.00 ns(-13.62%)Baseline: 353,221.09 ns | 658,973.62 ns (46.30%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 329,540.00 ns(-9.37%)Baseline: 363,625.94 ns | 596,980.65 ns (55.20%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 1,802.80 ns(-13.97%)Baseline: 2,095.53 ns | 2,833.17 ns (63.63%) |
| evaluate allow (identity/role/show) | 📈 view plot 🚷 view threshold | 70,994.00 ns(-21.18%)Baseline: 90,076.67 ns | 124,752.67 ns (56.91%) |
| evaluate deny (identity/role/show) | 📈 view plot 🚷 view threshold | 9,429.70 ns(-19.21%)Baseline: 11,672.34 ns | 15,509.14 ns (60.80%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,181.80 ns(-6.19%)Baseline: 1,259.80 ns | 1,745.35 ns (67.71%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.27 ns(-7.10%)Baseline: 0.29 ns | 0.37 ns (73.17%) |
| get_db | 📈 view plot 🚷 view threshold | 0.27 ns(-7.22%)Baseline: 0.29 ns | 0.37 ns (73.25%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 114.94 ns(-11.98%)Baseline: 130.58 ns | 180.03 ns (63.85%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 3.54 ns(-49.12%)Baseline: 6.96 ns | 16.28 ns (21.76%) |
| load all policies | 📈 view plot 🚷 view threshold | 360,400,000.00 ns(-15.29%)Baseline: 425,462,222.22 ns | 530,006,220.01 ns (68.00%) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Mutation::DropKeyspace, committed through Raft and applied on
every node, and StorageApi::list_keyspaces(prefix) for cleanup
discovery (ADR 0044 step 3).
DropKeyspace is accepted only for names matching
single_use_{use_case}_{bucket} with a numeric bucket, and only in a
transaction made of drops. Apply runs after the batch commits and
removes the keyspace, its per-record metadata in the meta keyspace
and any ephemeral entry. A missing keyspace is a no-op.
The real storage reported the first violation of any type as
Conflict, so a rate limit, quarantine or refused drop looked like
a replay. Violations other than CONFLICT now surface as the new
StoreError::Rejected, which keeps the violation type.
Move require_no_conflict from the scim, service-grant and
oauth2-client drivers into storage-api. It maps only a CONFLICT
violation or error to the caller's conflict and returns Rejected for
any other violation. The oauth2-key JTI retry loop uses it and no
longer retries a rejected write.
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com