Repository navigation
fix(oauth2): Allow only asymmetric algorithms in profiles - #1642
Open
thinhphucnguyen wants to merge 2 commits into
Open
thinhphucnguyen wants to merge 2 commits into
thinhphucnguyen wants to merge 2 commits into
Conversation
gtema
requested changes
Nov 13, 2026
gtema
left a comment
gtema
left a comment
Collaborator
There was a problem hiding this comment.
A very small nit, otherwise fine
| || profile.expected_issuers.iter().any(String::is_empty) | ||
| || profile.allowed_algorithms.is_empty() | ||
| || profile.allowed_algorithms.iter().copied().any(is_symmetric) | ||
| || !profile |
Collaborator
There was a problem hiding this comment.
This change now uncovers another inconsistency - mismatch of the algo would result in InvalidProfile error with "must specify issuers and audiences" which is pretty misleading for the algo error. Let's please add another error kind (e.g., DisallowedAlgorithm)
Signed-off-by: Thinh Phuc Nguyen <nguyenthinhphuc1901@gmail.com>
Signed-off-by: Thinh Phuc Nguyen <nguyenthinhphuc1901@gmail.com>
thinhphucnguyen
force-pushed
the
profile-followup
branch
from
November 14, 2026 12:41
e142419 to
10591e2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1639, addressing the review comments there:
EdDSA), so an algorithm added to jsonwebtoken later is refused until it is
listed.
against an EC-only JWKS. Both are rejected (InvalidKeyFormat), so no
verifier logic changes.
Also covers HS384 in the existing HMAC test.