Repository navigation
test: Stop integration tests bypassing providers - #1638
Merged
Merged
Conversation
Integration tests wrote to the database directly where the providers could be used instead. Create trusts through the trust provider rather than inserting trust rows. Add an optional last_verified argument to add_user_to_group_expiring and add_users_to_groups_expiring so tests can create an expired membership through the identity provider. None keeps the previous behaviour of stamping the current time. The LDAP driver ignores it. Drop the raw project_tag count from the integration test. Cover tag purging on project deletion with driver unit tests instead: a SQLite test with foreign keys enabled and a check that the schema of every backend carries ON DELETE CASCADE. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
enabled auto-merge
November 12, 2026 17:43
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
|
🧪 Tempest Identity Compatibility Results (advisory, non-blocking) rust Failed test IDs |
|
Bencher Report| Project | keystone |
| Branch | integration-tests |
| Testbed | ubuntu-latest |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| load all policies | Latency milliseconds (ms) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 454.52 ms(+2.68%)Baseline: 442.66 ms | 451.17 ms (100.74%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 122,680.00 ns(-1.87%)Baseline: 125,019.52 ns | 203,352.60 ns (60.33%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 132,920.00 ns(+1.30%)Baseline: 131,219.89 ns | 199,874.46 ns (66.50%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 131.44 ns(+14.18%)Baseline: 115.11 ns | 166.35 ns (79.01%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 115.45 ns(+11.82%)Baseline: 103.25 ns | 145.58 ns (79.30%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 217.08 ns(+14.89%)Baseline: 188.95 ns | 276.17 ns (78.60%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 115.06 ns(+11.48%)Baseline: 103.21 ns | 145.47 ns (79.10%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 172.04 ns(+20.04%)Baseline: 143.32 ns | 217.11 ns (79.24%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 146.29 ns(+20.46%)Baseline: 121.44 ns | 182.29 ns (80.25%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 271.06 ns(+21.73%)Baseline: 222.66 ns | 343.38 ns (78.94%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 141.96 ns(+17.59%)Baseline: 120.72 ns | 179.46 ns (79.10%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 128.45 ns(+20.05%)Baseline: 107.00 ns | 161.11 ns (79.73%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 211.80 ns(+9.34%)Baseline: 193.71 ns | 297.76 ns (71.13%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 169.69 ns(+16.77%)Baseline: 145.32 ns | 218.12 ns (77.80%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 295.43 ns(+30.07%)Baseline: 227.12 ns | 350.59 ns (84.27%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 3,356,500.00 ns(-5.20%)Baseline: 3,540,720.47 ns | 7,290,325.18 ns (46.04%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 35,238.00 ns(+7.68%)Baseline: 32,725.06 ns | 50,501.33 ns (69.78%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 339,480.00 ns(-2.72%)Baseline: 348,967.50 ns | 646,795.51 ns (52.49%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 370,970.00 ns(+2.34%)Baseline: 362,495.47 ns | 597,082.01 ns (62.13%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 2,108.80 ns(+0.32%)Baseline: 2,102.07 ns | 2,831.33 ns (74.48%) |
| evaluate allow (identity/role/show) | 📈 view plot 🚷 view threshold | 96,799.00 ns(+1.21%)Baseline: 95,642.71 ns | 105,909.09 ns (91.40%) |
| evaluate deny (identity/role/show) | 📈 view plot 🚷 view threshold | 12,083.00 ns(-1.61%)Baseline: 12,280.29 ns | 13,645.96 ns (88.55%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,414.00 ns(+12.12%)Baseline: 1,261.12 ns | 1,756.67 ns (80.49%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.31 ns(+6.05%)Baseline: 0.29 ns | 0.38 ns (83.02%) |
| get_db | 📈 view plot 🚷 view threshold | 0.31 ns(+6.81%)Baseline: 0.29 ns | 0.38 ns (83.83%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 146.66 ns(+12.17%)Baseline: 130.75 ns | 181.09 ns (80.99%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.15 ns(-41.23%)Baseline: 7.07 ns | 16.34 ns (25.41%) |
| load all policies | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 454,520,000.00 ns(+2.68%)Baseline: 442,664,285.71 ns | 451,173,629.83 ns (100.74%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests wrote to the database directly where the providers
could be used instead.
Create trusts through the trust provider rather than inserting trust
rows. Add an optional last_verified argument to
add_user_to_group_expiring and add_users_to_groups_expiring so tests
can create an expired membership through the identity provider. None
keeps the previous behaviour of stamping the current time. The LDAP
driver ignores it.
Drop the raw project_tag count from the integration test. Cover tag
purging on project deletion with driver unit tests instead: a SQLite
test with foreign keys enabled and a check that the schema of every
backend carries ON DELETE CASCADE.
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com