Repository navigation
Conversation
added 5 commits
October 14, 2026 12:55
…o SML process and sensor descriptions
…o viewing protected List fields that have public getters
alexrobin
requested changes
Nov 4, 2026
| } | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Can we avoid this by making it an ArrayList in the config rather than a Collection?
Contributor
Author
There was a problem hiding this comment.
The issue here is that the collection/list (these are already List<String>) fields in ResponsibleParty are protected, so those fields do not show up in the UI. This seems to be an existing bug as the list fields don't show up in the UI from OGCServiceConfig. For example, go to SOS Service -> Capabilities Info, and you will see that the list fields (voiceNumbers, faxNumbers, deliveryPoints, and emails) do not show up.
Contributor
Author
There was a problem hiding this comment.
The unit test in TestResponsiblePartyProperties is for confirming this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes a small existing UI bug that would not display protected
Listconfig fields from theResponsiblePartyclass (and other classes with protected fields but public accessors).The identification info is used to override the system UID, optional system kind UID, and contact information in the system description for both sensor drivers and processes.