Repository navigation
comm-mqtt: clear the "Waiting for MQTT server..." status when the server is already started - #276
Merged
Merged
Conversation
alexrobin
approved these changes
Nov 12, 2026
alexrobin
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a wrong status in the Admin UI: an MQTT service module showed "Waiting for MQTT server..." after it had started.
Closes #268. Part of #249.
Problem
AbstractMqttServiceModule.start()set the status afterregisterListener. When the MQTT Server is already started,registerListenerstarts the service and clears the status immediately. The status set after that call stayed until the MQTT Server restarted. This occurs each time a service module restarts while the MQTT Server runs.Fix
registerListener, so the start of the service clears it.versionline and inherited 2.0.1.Testing
TestAbstractMqttServiceModule(the module had no tests):Independent of the csapi-mqtt stack and of #262. It merges cleanly with master.