Repository navigation
Only keep server teams and remove teams which strategy is not compatible with engine version - #95
Open
DivineThreepwood wants to merge 2 commits into
Open
DivineThreepwood wants to merge 2 commits into
DivineThreepwood wants to merge 2 commits into
Conversation
tommy33790
reviewed
Oct 15, 2026
tommy33790
left a comment
tommy33790
left a comment
Contributor
There was a problem hiding this comment.
I sadly couldn't test/debug it at all without a server. On paper, I haven't found anything particular wrong.
It's a bit weird to have a deleteTeamFile-function which is not used by removeTeamsNotFromServer (only removeTeamsWithUnavailableStrategies references is).
| try { | ||
| val teamFolder = JPService.getProperty(JPTeamPath::class.java).value.canonicalFile | ||
| val teamFile = File(teamFolder, "$teamName.team").canonicalFile | ||
| if (teamFile.parentFile != teamFolder || teamFile.name == "default.team") { |
Contributor
There was a problem hiding this comment.
Just making sure: teamFile.parentFile != teamFolder is there to prevent directory traversal, isn't it?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Changes proposed in this pull request: