Reimplement distance check via ai and optimize performance.

[DivineThreepwood]

📜 Description

Changes proposed in this pull request:

• Improve goToMarker and goToSupportAgent performance by
  • choosing a more efficient distance represenation
  • caching distance map if possible
  • optimize locking strategy

Test Procedure

• Please test if navigation to marker and navigation to support agents is performed as expected.

[tommy33790]

The pipeline didn't compile.
And see comments about smaller unused / potentially unnecessary code.

I'm unsure about that whole Thread.currentThread().isInterrupted-stuff - whether it's useful or unnecessary.

[tommy33790]

Is DistanceMapCache per level necessary if it's always cleared when starting a game (in AbstractLevel.reset() via clearDistanceMapCache)?

[DivineThreepwood]

We’ll keep the distance-map cache scoped per level, with a maximum of 128 recently used maps per level. Since the game lifecycle allows only one active level at a time, AbstractLevel.reset() will clear the entire cache, rather than removing only that level’s entry. This promptly releases cached maps for inactive levels while preserving level isolation, so distance maps from different layouts cannot be mixed.

[tommy33790]

I still don't get the reasoning / implementation behind distanceMapCaches. It's a mapping for Level -> DistanceMapCache but it's cleared when starting a level. Thus, it will never contain more than one single Level & DistanceMapCache (which itself has up to 128 cached distances). If you start a game with the same level you just had, it's still cleared and all distances need to be recalculated.
With this implementation it's essentially used to store a single DistanceMapCache (that of the current level). So why is it a HashMap for Level -> DistanceMapCache?

Please think about once again.
After that, if you're still convinced that it's implemented / used correctly, then I'm fine with it.
It's just that I, myself, cannot grasp why it's the way it is.

I don't want to prevent a really good improvement with my cluelessness tho.

[tommy33790]

stablePosition has no references.

[DivineThreepwood]

All requested changes addressed.

[Jodi-Pa]

Currently the agents struggle to decide to which agent they should go, if multiple agents are requesting support.

[tommy33790]

Looking really good.
Just think about my one new comment (/genuine)

And then merge it.

[tommy33790]

I still don't get the reasoning / implementation behind distanceMapCaches. It's a mapping for Level -> DistanceMapCache but it's cleared when starting a level. Thus, it will never contain more than one single Level & DistanceMapCache (which itself has up to 128 cached distances). If you start a game with the same level you just had, it's still cleared and all distances need to be recalculated.
With this implementation it's essentially used to store a single DistanceMapCache (that of the current level). So why is it a HashMap for Level -> DistanceMapCache?

Please think about once again.
After that, if you're still convinced that it's implemented / used correctly, then I'm fine with it.
It's just that I, myself, cannot grasp why it's the way it is.

I don't want to prevent a really good improvement with my cluelessness tho.

[DivineThreepwood]

@Jodi-Pa is

Currently the agents struggle to decide to which agent they should go, if multiple agents are requesting support.

still an issue?

[Jodi-Pa]

@Jodi-Pa is

Currently the agents struggle to decide to which agent they should go, if multiple agents are requesting support.

still an issue?

I think it is still an issue, @tommy33790 has looked deeper into it, maybe she knows more.

I only managed to capture one, fairly nondescript , video of it today, i will send it to you.