[benderl]

No description provided.

[Copilot]

🟡 Changes recommended

The subshell’s error handling allows failed validation to proceed with installation and report success.

1 open issue

• Subshell under OR-list bypasses error handling · New

What changed in this PR

Adds installation of custom PHP 7.4 packages for the php2shell fix on supported Debian 11 platforms.

Changes:

• Selects platform-specific archives for Raspbian armhf and Debian amd64.
• Checks installed package versions to avoid reapplying the fix.
• Adds checksum validation, package installation, Apache restart handling, and temporary-file cleanup.

File	Description
runs/​install_packages.sh	Adds the platform-specific PHP 7.4 upgrade procedure.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Package-state detection needs correction, and system PHP replacement and Apache recovery require human validation on both supported platforms.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Verify all required PHP packages before skipping the fix

runs/​install_packages.sh:38

Missing or unconfigured PHP packages are treated as if the fix were already applied: dpkg-query can omit missing packages, and the installed filter ignores all other states, leaving needed at zero. Since the preceding package installation does not abort on failure, an incomplete installation can skip the repair, print “already applied,” and exit successfully. Require all three packages to be installed with the custom version before skipping the fix.

1 resolved since last review

• Subshell under OR-list bypasses error handling

_{Review effort: Balanced}