Repository navigation
remove outdated vehicle prio - #4177
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changes break simple-card rendering and remove charge-mode visibility and selection from normal cards.
2 open issues
What changed in this PR
Removes the outdated vehicle-priority setting from the cards display and the Koala and classic web themes.
Changes:
- Removes priority controls and indicators from charge-point interfaces.
- Deletes priority-specific store accessors and update handlers.
- Deletes Koala’s dedicated priority component.
| File | Description |
|---|---|
packages/modules/web_themes/standard_legacy/web/index.html |
Removes the classic theme’s priority toggle. |
packages/modules/web_themes/koala/source/src/stores/mqtt-store.ts |
Removes the priority accessor and export. |
packages/modules/web_themes/koala/source/src/components/ChargePointSettings.vue |
Removes the priority setting and import. |
packages/modules/web_themes/koala/source/src/components/ChargePointPriority.vue |
Deletes the priority component. |
packages/modules/web_themes/koala/source/src/components/ChargePointCard.vue |
Removes the priority control and import. |
packages/modules/display_themes/cards/source/src/views/ChargePointsView.vue |
Removes the priority update handler. |
packages/modules/display_themes/cards/source/src/stores/mqtt.js |
Removes the priority getter. |
packages/modules/display_themes/cards/source/src/components/ChargePoints/ChargePointCard.vue |
Removes the charge-mode badge containing the priority icon. |
packages/modules/display_themes/cards/source/src/components/ChargePoints/ChargeModeModal.vue |
Removes priority controls and their handler. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped removals are consistent across the affected interfaces, with no unresolved issues or remaining source references to the deleted component and accessors identified.
No open issues 🎉
2 resolved since last review
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove outdated prio setting in