Repository navigation
[Fix #1215] Updating Javascript example - #1216
Merged
Merged
Conversation
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the JavaScript stdin example’s switch to readLine().
No open issues 🎉
What changed in this PR
Updates the JavaScript stdin example for issue #1215, replacing Node.js-specific input handling with the requested readLine() approach.
Changes:
- Removes the
node:fsimport andreadFileSync(process.stdin.fd, 'utf8')call. - Uses
readLine()directly when logging stdin; argument and environment examples remain unchanged.
| File | Description |
|---|---|
examples/run-script-with-stdin-and-arguments.yaml |
Replaces Node.js-specific stdin reading with readLine(). |
Review effort: Balanced
ricardozanini
approved these changes
Nov 10, 2026
fjtirado
changed the title
Merged
6 of 8 tasks
cdavernas
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please specify parts of this PR update:
Discussion or Issue link:
Fix #1215
What this PR does:
Update the example as indicated in the issue