Repository navigation
[Fix #1203] Clarify HTTP response headers access in documentation and CTK - #1205
Conversation
…access in documentation and CTK - Add an example and note to dsl-reference.md demonstrating how with.output: response can be used to access HTTP response headers and status code via output.as - Add CTK scenario for HTTP response output with output filtering - Add examples/call-http-output-headers.yaml workflow example Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
Active critical and moderate issues leave the strict output.as examples and scenario functionally incorrect, with an additional weak header assertion.
4 open issues
What changed in this PR
This pull request documents how workflows can access HTTP response metadata, including headers, by selecting output: response and projecting response fields. It also adds a reusable example and CTK coverage.
Changes:
- Documents response content and header projections in
dsl-reference.md. - Adds an example workflow demonstrating HTTP response header access.
- Adds a CTK scenario covering
output: responsewithoutput.as.
This pull request requires changes.
| File | Reviewed changes and findings |
|---|---|
examples/call-http-output-headers.yaml |
Demonstrates extracting response content and headers. Moderate finding (2 votes): .content and .headers must be wrapped as ${ .content } and ${ .headers } runtime expressions. |
dsl-reference.md |
Documents response metadata access. Moderate finding (2 votes): the example must delimit .content and .headers as ${ .content } and ${ .headers }. |
ctk/features/call.feature |
Adds conformance coverage for response filtering. Critical finding (1 vote): object-form output.as values require ${...} delimiters. Nit (2 votes): strengthen the header assertion to verify an actual header value or non-empty headers map. |
Review effort: Lite
cdavernas
left a comment
There was a problem hiding this comment.
LGTM, aside from Copilot's review
…Type in CTK Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
A moderate conformance-test issue remains because the header assertion assumes one casing for a case-insensitive HTTP header name, potentially rejecting conforming runtimes.
1 open issue
4 resolved since last review
Review effort: Lite
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, and the change includes the requested documentation, example workflow, and conformance coverage for HTTP response metadata and header projections.
No open issues 🎉
1 resolved since last review
Review effort: Lite
3e2eefc
into
open-workflow-specification:main



Fixes #1203.
Clarifies how HTTP response headers and other response metadata can be accessed in workflow definitions.
Changes:
dsl-reference.mdwith an example and a note showing howoutput: responseunderwithproduces the full HTTP response object (includingheaders), which can then be projected usingoutput.asorexport.asctk/features/call.featuretestingoutput: responsecombined withoutput.asexamples/call-http-output-headers.yamldemonstrating this pattern