feat: handle blank canvas state in Diagram Editor by kumaradityaraj · Pull Request #535 · open-workflow-specification/editor

kumaradityaraj · 2026-11-12T08:11:32Z

closes - #418

Summary

Add a localized empty state for blank or whitespace-only workflow content.
Show a loading status while updated content is being parsed, avoiding a transient parsing error during empty-to-valid transitions.
Add tests for blank content and transitions between empty and populated diagrams.

Screenshot

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

changeset-bot · 2026-11-12T08:11:41Z

🦋 Changeset detected

Latest commit: 1b97f39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@openworkflowspec/diagram-editor	Minor
@openworkflowspec/core	Minor
@openworkflowspec/i18n	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify · 2026-11-12T08:11:45Z

✅ Deploy Preview for openworkflow-editor ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`1b97f39`
🔍 Latest deploy log	https://app.netlify.com/projects/openworkflow-editor/deploys/6af6c874f935258e2797cc48
😎 Deploy Preview	https://deploy-preview-535--openworkflow-editor.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot

🟡 Changes recommended

Loading a workflow through the ref from a blank editor leaves the canvas hidden, while missing backgrounds make empty and loading state text unreadable in dark mode on white hosts.

2 open issues

What changed in this PR

Adds blank-canvas handling to the Diagram Editor for issue #418, giving users guidance when workflow content is empty.

Changes:

Adds localized empty-state guidance and a loading status.
Tracks parse completion to avoid transient parsing errors.
Tests blank-content transitions and updates dual-editor test mocks.

File	Description
`packages/open-workflow-diagram-editor/tests/test-utils/render-helpers.tsx`	Adds parse-completion state to mock context.
`packages/open-workflow-diagram-editor/tests/diagram-editor/DiagramEditor.test.tsx`	Tests blank content and empty/populated transitions.
`packages/open-workflow-diagram-editor/src/styles.css`	Styles empty and loading states for both themes.
`packages/open-workflow-diagram-editor/src/store/DiagramEditorContextProvider.tsx`	Tracks content processed through props and imperative loading.
`packages/open-workflow-diagram-editor/src/store/DiagramEditorContext.tsx`	Exposes processed content in the context type.
`packages/open-workflow-diagram-editor/src/i18n/locales/en.ts`	Adds English empty-state and loading messages.
`packages/open-workflow-diagram-editor/src/diagram-editor/DiagramEditor.tsx`	Selects empty, loading, error, or diagram views.
`packages/dual-editor/tests/DualEditor.test.tsx`	Replaces state-based textarea mocks with ref-backed mocks.

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

The blank-prop check keeps the empty state visible after a successful imperative setContent call, hiding the loaded workflow and breaking the documented loading API.

2 open issues

_{Review effort: Balanced}

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot

🔵 Needs a closer look

Human assessment is needed because the tests check only the post-effect DOM and cannot rule out a transient parsing-error alert during the blank-to-valid transition.

No open issues 🎉

2 resolved since last review

_{Review effort: Balanced}

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot

🔵 Needs a closer look

Human assessment is needed because the regression test can pass when the wrapper mounts, before workflow nodes render or asynchronous layout errors surface.

No open issues 🎉

_{Review effort: Balanced}

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot

🟢 Approval recommended

No active review issues are recorded for the blank-canvas handling change.

No open issues 🎉

_{Review effort: Balanced}

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot

🟢 Approval recommended

No active review issues are reported for the Diagram Editor’s blank-canvas and content-transition changes.

No open issues 🎉

_{Review effort: Balanced}

lornakelly · 2026-11-12T14:49:27Z

Thanks @kumaradityaraj , one very small comment on wording

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot

🟢 Approval recommended

No active review issues block the Diagram Editor’s blank-canvas and loading-state improvements.

No open issues 🎉

_{Review effort: Balanced}

kumaradityaraj · 2026-11-13T09:31:10Z

@lornakelly ready for review again.

lornakelly

LGTM

kumaradityaraj added 2 commits November 12, 2026 13:37

Handling blank canvas

64e2af8

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Merging upstream

42d21ce

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot AI balanced review requested due to automatic review settings November 12, 2026 08:11

Copilot started reviewing on behalf of kumaradityaraj November 12, 2026 08:11

View session

changset added

a06fa55

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Comment thread packages/open-workflow-diagram-editor/src/diagram-editor/DiagramEditor.tsx Resolved

Comment thread packages/open-workflow-diagram-editor/src/styles.css Resolved

Copilot AI balanced review requested due to automatic review settings November 12, 2026 08:15

Copilot started reviewing on behalf of kumaradityaraj November 12, 2026 08:15

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Copilot suggestions

6506718

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot AI balanced review requested due to automatic review settings November 12, 2026 08:23

Copilot started reviewing on behalf of kumaradityaraj November 12, 2026 08:24

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Copilot suggestions

e2e0e41

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot AI balanced review requested due to automatic review settings November 12, 2026 08:34

Copilot started reviewing on behalf of kumaradityaraj November 12, 2026 08:34

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Copilot suggestions

b0445db

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot AI balanced review requested due to automatic review settings November 12, 2026 08:45

Copilot started reviewing on behalf of kumaradityaraj November 12, 2026 08:46

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

dummy push

81d8dd5

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot AI balanced review requested due to automatic review settings November 12, 2026 08:56

dummy push

664b867

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot started reviewing on behalf of kumaradityaraj November 12, 2026 08:57

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

kumaradityaraj requested review from fantonangeli and lornakelly November 12, 2026 09:11

kumaradityaraj requested a review from handreyrc November 12, 2026 09:11

fantonangeli approved these changes Nov 12, 2026

View reviewed changes

lornakelly reviewed Nov 12, 2026

View reviewed changes

Comment thread packages/open-workflow-diagram-editor/src/i18n/locales/en.ts Resolved

I18n changes

1b97f39

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>

Copilot AI balanced review requested due to automatic review settings November 13, 2026 08:21

Copilot started reviewing on behalf of kumaradityaraj November 13, 2026 08:21

View session

Copilot AI reviewed Nov 13, 2026

View reviewed changes

kumaradityaraj requested a review from lornakelly November 13, 2026 09:31

lornakelly approved these changes Nov 13, 2026

View reviewed changes

Conversation

kumaradityaraj commented Nov 12, 2026

Summary

Screenshot

Uh oh!

changeset-bot Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

netlify Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for openworkflow-editor ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

lornakelly commented Nov 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

kumaradityaraj commented Nov 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lornakelly left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot Bot commented Nov 12, 2026 •

edited

Loading

netlify Bot commented Nov 12, 2026 •

edited

Loading

kumaradityaraj commented Nov 13, 2026 •

edited

Loading