Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the Swoole multipart upload hardening from appwrite/appwrite#14897, which shipped in utopia-php/http 2.0.0-rc35. The http constraint gets a floor of
^2.0.0-rc35so older releases can't come back through a lock refresh.rc34+ requires
utopia-php/validators^2.0.utopia-php/storage4.4.x still required ^1.0, so this also moves storage to 4.5.0, the first release on validators 2. No aliases.The validators 2.0 break is limited to moving the base class
Utopia\Validator(shimmed until 3.0). The executor only uses concrete validators (Text,Integer,Boolean,WhiteList,Assoc,AnyOf,FloatValidator), whose names don't change.Storage 4.5.0 brings the S3 fixes since 4.4.1: recursive deletes that remove whole directories and refuse whole-bucket or out-of-root deletes, path-style bucket addressing, and streamed reads. Appwrite Cloud already runs 22 of those 23 commits in production.
Verified on Swoole 6.2.0 (the
phpswoole/swoole:6.2.0CI image and the executor'sutopia-base:php-8.5-2.0.0base image):composer test:unit: 37 tests OKcomposer analyze(PHPStan): no errorscomposer refactor:checkandcomposer format:check: cleanSwooleCoroutine\Server+Httpstack with a/v1/healthroute answers GET with 200 "ok" on both rc32 and rc35. The upload hardening takes effect on rc35 and not on rc32.The E2E suite needs a Docker socket and runtimes, so CI is the check for that.
🤖 Generated with Claude Code