Repository navigation
Conversation
A bucket variant can be any JSON Logic expression. The variant is already passed through untouched, so this loosens the type hints to match and adds tests for a computed variant and a non-scalar result. Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #482
The Python fractional operator already returned whatever the variant expression evaluated to, so computed variants like
{"cat": ["r", "ed"]}worked. I loosened the type hints to say so (Fraction.variantand the return type are nowAny) and added tests for a computed variant, picking a bucket by weight, and a non-scalar result being passed through. This is so the upcomingresolveoperator can be used as a bucket variant.I ran
tests/test_targeting.pylocally on Python 3.12 and it passes, and ruff is clean.