Skip to content

feat!: drop the legacy gherkin/ suite for tck-extensions/ - #450

Merged
aepfli merged 1 commit into
feat/tck-extensionsfrom
feat/v4-drop-gherkin
Nov 16, 2026
Merged

aepfli merged 1 commit into
feat/tck-extensionsfrom
feat/v4-drop-gherkin

Conversation

@aepfli

@aepfli aepfli commented Nov 16, 2026

Copy link
Copy Markdown
Member

Stacked on #445. Makes 4.0 the release that drops the legacy gherkin/ e2e suite. flagd providers run tck-extensions/ through the Provider TCK instead (open-feature/spec#417).

  • Deletes gherkin/. The image, launchpad/, flags/ and evaluator/ stay, since the extensions and the evaluator testkits still need them.
  • Updates the README, agents.md and the extensions README to say where the scenarios live now.
  • The BREAKING CHANGE footer makes release-please on main cut 4.0.0.

SDKs still on gherkin/ keep getting 3.x releases from release/v3, which has its own release-please (#449). Both branches release independently: main cuts 4.x and owns :latest, while release/v3 cuts v3.x.

Every legacy scenario has a counterpart in tck-extensions/, or is listed in that file's header as not ported. That includes #446's, ported into #445.

🤖 Generated with Claude Code

BREAKING CHANGE: gherkin/ is removed. flagd providers run tck-extensions/
through the Provider TCK instead. SDKs still on the legacy suite pin a 3.x
release, which keeps being cut from the release/v3 branch.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
@aepfli
aepfli requested a review from a team as a code owner November 16, 2026 10:46
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 951b3fa6-7342-4422-908d-21ac844c1241

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@aepfli
aepfli merged commit 4d12d00 into feat/tck-extensions Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant