Repository navigation
feat!: drop the legacy gherkin/ suite for tck-extensions/ - #450
Merged
Merged
Conversation
BREAKING CHANGE: gherkin/ is removed. flagd providers run tck-extensions/ through the Provider TCK instead. SDKs still on the legacy suite pin a 3.x release, which keeps being cut from the release/v3 branch. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #445. Makes 4.0 the release that drops the legacy
gherkin/e2e suite. flagd providers runtck-extensions/through the Provider TCK instead (open-feature/spec#417).gherkin/. The image,launchpad/,flags/andevaluator/stay, since the extensions and the evaluator testkits still need them.agents.mdand the extensions README to say where the scenarios live now.BREAKING CHANGEfooter makes release-please on main cut 4.0.0.SDKs still on
gherkin/keep getting 3.x releases fromrelease/v3, which has its own release-please (#449). Both branches release independently: main cuts 4.x and owns:latest, whilerelease/v3cuts v3.x.Every legacy scenario has a counterpart in
tck-extensions/, or is listed in that file's header as not ported. That includes #446's, ported into #445.🤖 Generated with Claude Code