Repository navigation
fix: AssetMaker status default (ISSUE-148), remove get_engine_actions (ISSUE-151); log ISSUE-149/150 - #452
Closed
dwolfson wants to merge 6 commits into
Closed
fix: AssetMaker status default (ISSUE-148), remove get_engine_actions (ISSUE-151); log ISSUE-149/150#452dwolfson wants to merge 6 commits into
dwolfson wants to merge 6 commits into
Conversation
…PROGRESS, dropping journal entries) Reported by the egeria-workspaces-fs session. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…SSUE-148) Seven AssetMaker action/process queries (find_processes, get_processes_by_category, get_action_targets, get_actions_for_action_target, get_assigned_actions, get_actions_for_sponsor, get_actions_for_requester) defaulted to ["IN_PROGRESS"], which silently dropped journal entries and every finished action. _async_find_processes defaulted to [] while its sync wrapper used ["IN_PROGRESS"], so the two disagreed. All 14 signatures now default to None. Behaviour change: callers that want only in-progress actions must pass ["IN_PROGRESS"] explicitly. No known caller relies on the old default (checked with the egeria-workspaces-fs and trellis sessions). Noted for the 6.2.3 release notes in BACKLOG.md. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…unction Dr.Egeria family); 137/141 shipped in 6.2.2 Handed off by the Resource Explorer PR/CI session on the owner's instruction, from trellis' analytic walking-skeleton brief. A1-A5 of the handoff were already logged as ISSUE-137..141 (137 and 141 are fixed and released in 6.2.2). Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…ath that doesn't exist)
Reported by the RE PR/CI session; confirmed from AutomatedCurationResource
and a read-only live check. find_engine_actions("*") is the working route.
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…dpoint (ISSUE-151)
get_engine_actions posted to automated-curation/engine-actions, which
AutomatedCurationResource does not map, so it always failed with a 404
(reported as "unable to connect"). EngineAction is an Asset in 6.2, so
find_engine_actions("*") is the list-all; print_engine_actions now uses
it. No callers outside egeria-python (checked egeria-workspaces-fs and
trellis). API removal noted for the 6.2.3 release notes.
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
4 tasks done
Member
Author
|
Closing as superseded: #453 was stacked on this branch, so its squash merge (cd57aa6) already carries every commit here. That covers the ISSUE-148 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#451 was merged at
7910825b, before the last two commits on its branch were included. This PR carries those two commits: the ISSUE-148 fix and its issue-log entry. It also removesget_engine_actions(ISSUE-151), and logs two new issues handed off from trellis' Analytic Library work (ISSUE-149/150).ISSUE-148: AssetMaker action queries default to no status filter
find_processes,get_processes_by_category,get_action_targets,get_actions_for_action_target,get_assigned_actions,get_actions_for_sponsorandget_actions_for_requester(sync and async) defaultedactivity_status_listto["IN_PROGRESS"]. That silently dropped journal entries (which have no activity status) and every finished action. They now default toNone._async_find_processesdefaulted to[], while its sync wrapper used["IN_PROGRESS"].["IN_PROGRESS"]explicitly. The egeria-workspaces-fs and trellis sessions checked their callers, and none relies on the old default.ISSUE-151: remove
AutomatedCuration.get_engine_actions()automated-curation/engine-actions, which Egeria'sAutomatedCurationResourcedoesn't map, so it always got a 404 (which pyegeria reported as "unable to connect").find_engine_actions("*")is the list-all (checked live, read-only: it returned a full page).print_engine_actionsnow usesfind_engine_actions, and the functional test is nowtest_find_all_engine_actions. A search of egeria-workspaces-fs and trellis found no callers.Issue log
AnalyticFunctionSpeclacks the manifest fields trellis-analytics needs (kind,source,version,envelope,annotation_type,resource_types). It has three points to settle before building.GovernanceActionTypeor an alternative) is an open question for the Egeria leads.Test plan
tests/micro-tests/test_issue_148_activity_status_default.py: for all 7 methods, the default sends noactivityStatusList, and an explicit filter is still senttests/micro-tests/test_issue_151_engine_actions_list_all.py: the method is gone, andprint_engine_actionshitsassets/by-search-stringwithEngineAction🤖 Generated with Claude Code