Skip to content

fix: AssetMaker status default (ISSUE-148), remove get_engine_actions (ISSUE-151); log ISSUE-149/150 - #452

Closed
dwolfson wants to merge 6 commits into
odpi:mainfrom
dwolfson:fix/issue-148-activity-status-default
Closed

dwolfson wants to merge 6 commits into
odpi:mainfrom
dwolfson:fix/issue-148-activity-status-default

Conversation

@dwolfson

@dwolfson dwolfson commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Summary

#451 was merged at 7910825b, before the last two commits on its branch were included. This PR carries those two commits: the ISSUE-148 fix and its issue-log entry. It also removes get_engine_actions (ISSUE-151), and logs two new issues handed off from trellis' Analytic Library work (ISSUE-149/150).

Two changes for the 6.2.3 release notes (both noted in BACKLOG.md):

  • Behaviour change (ISSUE-148): seven AssetMaker action/process queries no longer filter to IN_PROGRESS by default.
  • API removal (ISSUE-151): AutomatedCuration.get_engine_actions() is removed. It always got a 404; use find_engine_actions("*").

ISSUE-148: AssetMaker action queries default to no status filter

  • find_processes, get_processes_by_category, get_action_targets, get_actions_for_action_target, get_assigned_actions, get_actions_for_sponsor and get_actions_for_requester (sync and async) defaulted activity_status_list to ["IN_PROGRESS"]. That silently dropped journal entries (which have no activity status) and every finished action. They now default to None.
  • Also fixes a mismatch: _async_find_processes defaulted to [], while its sync wrapper used ["IN_PROGRESS"].
  • Callers that want only open work must pass ["IN_PROGRESS"] explicitly. The egeria-workspaces-fs and trellis sessions checked their callers, and none relies on the old default.

ISSUE-151: remove AutomatedCuration.get_engine_actions()

  • It posted to automated-curation/engine-actions, which Egeria's AutomatedCurationResource doesn't map, so it always got a 404 (which pyegeria reported as "unable to connect").
  • EngineAction is an Asset in 6.2, so find_engine_actions("*") is the list-all (checked live, read-only: it returned a full page).
  • print_engine_actions now uses find_engine_actions, and the functional test is now test_find_all_engine_actions. A search of egeria-workspaces-fs and trellis found no callers.

Issue log

  • ISSUE-149 (open): AnalyticFunctionSpec lacks the manifest fields trellis-analytics needs (kind, source, version, envelope, annotation_type, resource_types). It has three points to settle before building.
  • ISSUE-150 (open, design blocked): Dr.Egeria commands for an Analytic Function's Egeria declaration. The element type (GovernanceActionType or an alternative) is an open question for the Egeria leads.
  • The statuses of ISSUE-137 and ISSUE-141 are corrected: both were fixed in fix: ISSUE-111/113/114/129/134/136/137/141; reorganize PYEGERIA_ISSUES.md #446 and shipped in 6.2.2.

Test plan

  • tests/micro-tests/test_issue_148_activity_status_default.py: for all 7 methods, the default sends no activityStatusList, and an explicit filter is still sent
  • tests/micro-tests/test_issue_151_engine_actions_list_all.py: the method is gone, and print_engine_actions hits assets/by-search-string with EngineAction
  • Full micro-test suite passes (1131 tests)

🤖 Generated with Claude Code

…PROGRESS, dropping journal entries)

Reported by the egeria-workspaces-fs session.

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…SSUE-148)

Seven AssetMaker action/process queries (find_processes,
get_processes_by_category, get_action_targets,
get_actions_for_action_target, get_assigned_actions,
get_actions_for_sponsor, get_actions_for_requester) defaulted to
["IN_PROGRESS"], which silently dropped journal entries and every
finished action. _async_find_processes defaulted to [] while its sync
wrapper used ["IN_PROGRESS"], so the two disagreed. All 14 signatures
now default to None.

Behaviour change: callers that want only in-progress actions must pass
["IN_PROGRESS"] explicitly. No known caller relies on the old default
(checked with the egeria-workspaces-fs and trellis sessions). Noted for
the 6.2.3 release notes in BACKLOG.md.

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…unction Dr.Egeria family); 137/141 shipped in 6.2.2

Handed off by the Resource Explorer PR/CI session on the owner's
instruction, from trellis' analytic walking-skeleton brief. A1-A5 of
the handoff were already logged as ISSUE-137..141 (137 and 141 are
fixed and released in 6.2.2).

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…ath that doesn't exist)

Reported by the RE PR/CI session; confirmed from AutomatedCurationResource
and a read-only live check. find_engine_actions("*") is the working route.

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…dpoint (ISSUE-151)

get_engine_actions posted to automated-curation/engine-actions, which
AutomatedCurationResource does not map, so it always failed with a 404
(reported as "unable to connect"). EngineAction is an Asset in 6.2, so
find_engine_actions("*") is the list-all; print_engine_actions now uses
it. No callers outside egeria-python (checked egeria-workspaces-fs and
trellis). API removal noted for the 6.2.3 release notes.

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
@dwolfson dwolfson changed the title fix(asset-maker): default activity_status_list to no filter (ISSUE-148); log ISSUE-149/150 fix: AssetMaker status default (ISSUE-148), remove get_engine_actions (ISSUE-151); log ISSUE-149/150 Oct 14, 2026
@dwolfson

Copy link
Copy Markdown
Member Author

Closing as superseded: #453 was stacked on this branch, so its squash merge (cd57aa6) already carries every commit here. That covers the ISSUE-148 activity_status_list default, the ISSUE-151 removal of get_engine_actions, and the ISSUE-149/150/151 log entries. main matches #453's final head exactly, so the conflicts are only those duplicate changes.

@dwolfson dwolfson closed this Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant