Skip to content

fix: ISSUE-111/113/114/129/134/136/137/141; reorganize PYEGERIA_ISSUES.md - #446

Merged
dwolfson merged 3 commits into
odpi:mainfrom
dwolfson:docs/issue-136
Oct 13, 2026
Merged

dwolfson merged 3 commits into
odpi:mainfrom
dwolfson:docs/issue-136

Conversation

@dwolfson

Copy link
Copy Markdown
Member

Summary

Fixes eight issues from PYEGERIA_ISSUES.md and reorganizes the file so open items come first.

Fixes

  • ISSUE-136: get_notes_for_note_log, get_note_by_guid and find_notes now default to type Note. The old default, Action, is a supertype, so it also matched every Notification. The issue's "missing endpoint" diagnosis was wrong: AssetMakerResource serves that URL.
  • ISSUE-134: @dynamic_catch re-raises when PYEGERIA_ENABLE_LOGGER_CATCH is on. Before, logger.catch(func, reraise=True) ignored the keyword, so every failure came back as None.
  • ISSUE-129: MetadataExpert's relationship queries now send startFrom, pageSize, forLineage and forDuplicateProcessing in the body, plus startingAtEnd where the endpoint takes it. Checked live, read-only.
  • ISSUE-111: with body=None, 11 ConnectionMaker/DataDiscovery link methods now send the real relationship properties class. Before, they sent the relationship type name, which Egeria rejected. Live-tested for all six ConnectionMaker links: the old request shape gets an HTTP 400, and each new link was created and read back by a different route. The throwaway elements were deleted.
  • ISSUE-141: ActionParameter.function is optional when analytic_function is set.
  • ISSUE-137: exec_report_spec builds an EgeriaTech client, and gets a token, only when the analytic routine takes a client parameter.
  • ISSUE-113: Egeria removed initialStatus (2025-12-15). Dr.Egeria now puts Status in the property each element type actually has: contentStatus, activityStatus, deploymentStatus, or none.
    • The type table is generated from Egeria's Java source by scripts/gen_element_status_fields.py.
    • A status the user wrote beats spec defaults.
    • Glossary CSV import/export and the create_glossary_term CLI use contentStatus. The CLI was also dropping all term properties; that's fixed too.
    • The template-based Create Element no longer sends initialStatus.
    • Live-tested: a Data Structure was stored with contentStatus: DRAFT and a Solution Component with deploymentStatus: UNDER_DEVELOPMENT. Both were then deleted.
  • ISSUE-114: the sentinel return convention is kept. A new helper, pyegeria.guid_or_none(), makes existence checks after get_guid_for_name safe.

Docs

  • PYEGERIA_ISSUES.md now runs: open items, a new "Awaiting re-test" section, open Egeria Server issues, then closed entries in an appendix, newest first.
  • Logs ISSUE-137 to 141.

Not in this PR

  • 138–140: a separate design PR.
  • 127/132: waiting on an Egeria cascade-delete fix.
  • 123: still open.
  • Still to do in trellis for 141: the Advisor's validate_report_spec.

Test plan

  • pytest tests/micro-tests: 1071 passed, 1 skipped. A new micro-test covers each issue.
  • Live checks for 111, 113 and 129, as described above.

🤖 Generated with Claude Code

dwolfson and others added 3 commits October 11, 2026 17:33
…endpoint)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…_ISSUES.md

- 136: Note reads default to type "Note" (was "Action", which matched every
  Notification).
- 134: dynamic_catch re-raises under PYEGERIA_ENABLE_LOGGER_CATCH
  (logger.catch(reraise=True)(func); the keyword was being ignored).
- 129: MetadataExpert relationship queries now send paging/lineage options
  and startingAtEnd.
- 111: 11 ConnectionMaker/DataDiscovery link methods name the real
  relationship properties class in their default body (live-verified for
  the six ConnectionMaker links).
- 141: ActionParameter.function is optional when analytic_function is set.
- 137: exec_report_spec only builds an EgeriaTech client when the analytic
  routine takes one.
- 113: Dr.Egeria puts Status in the property each type has (contentStatus /
  activityStatus / deploymentStatus, table generated from Egeria source);
  initialStatus no longer sent (removed by Egeria 2025-12-15); glossary CSV
  import/export and create_glossary_term CLI use contentStatus.
- 114: add pyegeria.guid_or_none() for get_guid_for_name existence checks;
  sentinel convention kept.
- PYEGERIA_ISSUES.md: open items first, "Awaiting re-test" section, closed
  entries in an appendix; log ISSUE-137..141.

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
@dwolfson
dwolfson merged commit e66eefa into odpi:main Oct 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant