Repository navigation
tracing: forward the action journey on SDK calls - #97
Merged
Merged
Conversation
propagation_headers() gains X-Journey-ID forwarding (campus#828): when the host request carries an action journey (the journeys middleware stashes it as flask.g.journey_id), outbound SDK calls forward it so the receiving service's span joins the same journey. Trace headers and the journey header are independent — trace headers require span state on flask.g, the journey header only requires an active journey, so journeys work on hosts even where span tracing is off. 3 new tests; suite 249 OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to campus#834 (action journeys, campus#828): when the host request carries an action journey — the journeys middleware stashes it as
flask.g.journey_id— SDK calls forward it asX-Journey-ID, and receiving services (campus.api/auth adopt-only registrations) tag their spans with it. A classroom action episode therefore spans services in the audit UI.Design note: journey forwarding is independent of span-trace forwarding — trace headers still require span state on flask.g (the tracing middleware ran), while the journey header only requires an active journey. That keeps journeys meaningful on hosts even where span tracing is off.
3 new tests (forwarded inside a traced request; absent without a journey; journey-without-trace-context); suite 249 OK; ruff clean.