Repository navigation
feat(auth): complete auth coverage — clients access.check, Clients.new scope fields, Credentials.User.new - #83
Merged
Merged
Conversation
…fields, Credentials.User.new - Clients.Client.access.check(vault, permission): GET the /access/check leaf route with vault/permission query params - Clients.new(): forward allowed_scopes, upstream_scopes, token_bridge (update() has supported them since PR #65) - Credentials.Provider.User.new(scopes, expires_in): implement the stale NotImplementedError stub — POST /credentials/<provider>/ <user_id> sends {scopes, expires_in}; the client_id comes from the request's auth context, not the body Fixes #76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The three smaller auth-service gaps from the 2026-10-04 delta sweep (campus
weekly):Clients.Client.access.check(vault, permission)— GET/auth/v1/clients/<id>/access/check?vault=&permission=(leaf path, no trailing slash, matching the route registration) →{"vault": ..., "permission": <bool>}. The only access sub-route the client lacked.Clients.new()now forwardsallowed_scopes,upstream_scopes,token_bridge(omitted when not given), matching the POST/clients/route;update()has supported them since PR feat(auth): client update() accepts allowed_scopes/upstream_scopes/token_bridge #65.Credentials.Provider.User.new(scopes, expires_in)— implements the staleNotImplementedErrorstub. POST/auth/v1/credentials/<provider>/<user_id>with{scopes, expires_in}(the server takes client_id from the request's auth context, not the body); parses the 201 flat resource intoUserCredentials.Tests
tests/unit/test_auth_coverage.py— 4 contract tests (query params + path for check; body omission/forwarding for new(); POST path/body + deserialization for credentials). Full suite: 150 passed.Fixes #76