Repository navigation
fix(api): add Submissions.unsubmit() to clear submitted_at with explicit null - #78
Merged
Merged
Conversation
…cit null
The server only clears a submission's submitted_at for an explicit
null in the PATCH body (campus/api/resources/submission.py), but
update() treats None as "omit the field" — unsubmit was inexpressible.
unsubmit() PATCHes {"submitted_at": null} directly, mirroring submit().
Fixes #74
nycomp
force-pushed
the
bugfix/submissions-unsubmit
branch
from
October 4, 2026 01:47
3e80c10 to
1515b47
Compare
This was referenced Oct 4, 2026
ngjunsiang
added this pull request to stack #86
October 4, 2026 03:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Submissions.Submission.unsubmit(), which PATCHes{"submitted_at": null}— the only body the server interprets as clearingsubmitted_at(campus/api/resources/submission.py:60).update()cannot express this: itsNonemeans "omit the field", soupdate(submitted_at=None)raised the client's own "At least one field"ValueError. campus-classroom's unsubmit was inexpressible through the client.submit()action; unsubmit keepsupdate()'s contract unchanged (pinned by tests).Tests
tests/unit/test_submissions_unsubmit.py(same mock-client pattern astest_nested_resources.py):{"submitted_at": None}to/api/v1/submissions/<id>/Full suite: 149 passed (146 existing + 3 new).
Fixes #74