Repository navigation
fix(api): correct YAML indentation in API specs - #4656
Open
JorisHeadease wants to merge 1 commit into
Open
JorisHeadease wants to merge 1 commit into
JorisHeadease wants to merge 1 commit into
Conversation
Three specs close a flow sequence at the same indentation as its key. YAML 1.2.2 section 8.2.3 requires flow nodes to be indented by at least one more space than the parent block collection, so these files are not valid YAML. Indent the closing brackets one level further. See https://yaml.org/spec/1.2.2/#823-block-nodes The generated Go code is unchanged.
JorisHeadease
requested review from
Dirklectisch,
gerardsn,
reinkrul,
stevenvegt and
woutslakhorst
as code owners
October 29, 2026 16:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three specs are not valid YAML 1.2.2: a closing flow bracket sits at the same indentation as its key, while §8.2.3 requires flow nodes to be indented more than their parent block collection. Many parsers are lenient here; the YAML test matrix for 9C9N "Wrong indented flow sequence" shows several accepting an invalid case. js-yaml 5 reports it:
On
masterthis printsauth/v1.yaml,auth/v2.yamlandcommon/ssi_types.yaml; on this branch it prints nothing. The generated Go code is unchanged.