Repository navigation
Fix Go workflow build and trigger CI on main - #346
Merged
Merged
Conversation
- Go workflow: build the frontend before `go build`. `main.go` embeds `web/dist/*`, which is gitignored, so the build failed on every run. - Go and npm workflows: trigger on `main` instead of `master`, so they run on pull requests and merges, not only on tags. Assisted by AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go workflow has failed on every tag push (e.g. v6.5.3):
Cause
main.goembedsweb/dist/*, which is gitignored and only created bynpm run build.go buildon a clean checkout without it. This has been the case since the workflow was added.master.build-images.yamlwas switched tomainin 97c94d2 (2024-05), these two were not, so they only ran on tag pushes.Dockerfilebuilds the frontend itself.Changes
go-test.yaml: create an emptyweb/dist/.placeholderbeforego build, so the embed pattern matches. The frontend is not built here; the npm and Docker workflows already build it, and no Go test uses its files.go-test.yaml,npm-build.yaml: trigger onmaininstead ofmaster.Verification
node_modules: placeholder +go build ./...+go test ./...pass.npm run lint: 0 errors (8 existing warnings).Assisted by AI