Repository navigation
Conversation
tmakatos
force-pushed
the
config-durations
branch
from
October 23, 2026 07:13
3d6c2b7 to
b6b14f9
Compare
tmakatos
marked this pull request as draft
October 23, 2026 07:13
tmakatos
force-pushed
the
config-durations
branch
from
October 23, 2026 07:23
b6b14f9 to
3393c92
Compare
tmakatos
force-pushed
the
config-durations
branch
2 times, most recently
from
October 23, 2026 22:09
180df31 to
599df58
Compare
tmakatos
marked this pull request as ready for review
October 23, 2026 22:24
lforchini
reviewed
Oct 26, 2026
lforchini
left a comment
Collaborator
There was a problem hiding this comment.
Can you mention in the commit message why we're doing this change? Currently it just says how to cope with the restrictions it adds.
Still working on full review.
tmakatos
force-pushed
the
config-durations
branch
5 times, most recently
from
October 26, 2026 16:44
87ff267 to
e71d759
Compare
tmakatos
force-pushed
the
config-durations
branch
from
October 26, 2026 17:02
e71d759 to
5470ee2
Compare
Collaborator
Author
Updated the commit message. |
Expressing parameters in poll cycles makes it trivial for the implementation but harder for the operator to understand since they have to multiply the parameters by the poll cycle duration to get to the actual value. Express everything in seconds instead, even if that complicates the implementation. Durations are now integer seconds in settings ending in _secs: scale_poll_secs, cooldown_secs (now integers, were floats) scale_down_sustain_polls -> scale_down_sustain_secs scale_validation_sample_polls -> scale_validation_delay_secs scale_validation_sample_polls_per_thread -> scale_validation_delay_per_thread_secs post_revert_up_grace_polls -> post_revert_up_grace_secs post_revert_up_recovery_polls -> post_revert_up_recovery_secs post_revert_up_backoff_max_polls -> post_revert_up_backoff_max_secs scale_down_backoff_max_polls -> scale_down_backoff_max_secs Every duration must be a multiple of scale_poll_secs. The engine receives the poll period when it is built and converts its durations to polls once, so engine logic is unchanged. The daemon refuses to start if any duration, controller or engine, is not a multiple, listing all of them with the nearest valid values. The round_up_durations config option and --round-up-durations flag (both off by default) instead round such durations up with a warning, so that a new poll period can be tried without rewriting the config. The daemon now logs the effective controller, engine, and backend configuration at startup, which shows rounded values. The daemon also prints errors with Display rather than Debug. AI-generated: everything, manual fixup of the commit message Signed-off-by: Thanos Makatos <thanos.makatos@nutanix.com>
tmakatos
force-pushed
the
config-durations
branch
from
October 26, 2026 18:08
5470ee2 to
ee4289b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Durations are now integer seconds in settings ending in _secs:
scale_poll_secs, cooldown_secs (now integers, were floats)
scale_down_sustain_polls -> scale_down_sustain_secs
scale_validation_sample_polls -> scale_validation_delay_secs
scale_validation_sample_polls_per_thread -> scale_validation_delay_per_thread_secs
post_revert_up_grace_polls -> post_revert_up_grace_secs
post_revert_up_recovery_polls -> post_revert_up_recovery_secs
post_revert_up_backoff_max_polls -> post_revert_up_backoff_max_secs
scale_down_backoff_max_polls -> scale_down_backoff_max_secs
Every duration must be a multiple of scale_poll_secs. The engine
receives the poll period when it is built and converts its durations to
polls once, so engine logic is unchanged. The daemon refuses to start if
any duration, controller or engine, is not a multiple, listing all of
them with the nearest valid values.
The round_up_durations config option and --round-up-durations flag
(both off by default) instead round such durations up with a warning,
so that a new poll period can be tried without rewriting the config.
The daemon now logs the effective controller, engine, and backend
configuration at startup, which shows rounded values.
The daemon also prints errors with Display rather than Debug.
AI-generated: everything.
Stack created with GitHub Stacks CLI • Give Feedback 💬