fix(ui): ChangeHistory dropdown width collapses to its min-width - #9147
Open
btea wants to merge 2 commits into
Open
fix(ui): ChangeHistory dropdown width collapses to its min-width#9147btea wants to merge 2 commits into
btea wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new min-w-[12rem] can override the viewport-based max-w on very narrow viewports, potentially reintroducing horizontal overflow.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adjusts the ChangeHistory dropdown panel sizing so it no longer uses a fixed width, instead sizing to its content while remaining bounded by the viewport, addressing the UI concern raised in #9145.
Changes:
- Switches the dropdown wrapper from a fixed width (
w-[26rem]) to content-based sizing (w-max). - Updates the max-width constraint to cap at
min(26rem, 100vw - 2rem). - Introduces a minimum width (
min-w-[12rem]) for baseline readability/consistency.
File summaries
| File | Description |
|---|---|
| packages/ui-components/src/Common/ChangeHistory/index.module.css | Changes dropdown panel width behavior to be content-sized with viewport bounds and a minimum width. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: btea <2356281422@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #9145
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.