lib: optimize internal Web IDL dictionaries - #65857
Open
panva wants to merge 1 commit into
Open
Conversation
Flatten dictionary members at construction while preserving inheritance order. Skip member scans for nullish inputs without defaults or required members, and define own descriptor properties to avoid inherited setters. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Contributor
|
Benchmark GHA (misc / webcrypto-webidl): https://github.com/nodejs/node/actions/runs/34041429199 Results
Benchmark results:
|
panva
marked this pull request as ready for review
September 6, 2026 17:28
Member
Author
|
cc @nodejs/web-standards |
jasnell
approved these changes
Sep 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65857 +/- ##
==========================================
- Coverage 90.19% 90.19% -0.01%
==========================================
Files 771 771
Lines 264622 264619 -3
Branches 50223 50230 +7
==========================================
- Hits 238663 238660 -3
+ Misses 16965 16954 -11
- Partials 8994 9005 +11
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flatten dictionary members at construction while preserving inheritance order. Skip member scans for nullish inputs without defaults or required members, and define own descriptor properties to avoid inherited setters.