feat: add ncu-ci resume command - #1187
Open
panva wants to merge 2 commits into
Open
Conversation
Resume failed or aborted PR CI jobs when Jenkins exposes a resume action and the CI-approved commit still matches the PR head. Refuse when available failure diagnostics reference files changed by the PR. Refs: nodejs#642 Co-authored-by: Moshe Atlow <moshe@atlow.co.il> Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
+ Coverage 57.81% 58.45% +0.64%
==========================================
Files 53 59 +6
Lines 10396 11588 +1192
==========================================
+ Hits 6010 6774 +764
- Misses 4386 4814 +428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks
jasnell
approved these changes
Sep 9, 2026
Renegade334
reviewed
Sep 9, 2026
| validate() { | ||
| const { cli, prid, repo, owner } = this; | ||
| let validArgs = true; | ||
| if (!Number.isSafeInteger(prid) || prid <= 0) { |
Member
There was a problem hiding this comment.
Bold to assume that we won't have received 2^53 agentic PRs by the end of the year...
Comment on lines
+5
to
+6
| const diagnostic = /error:|error C\d+:|Error:|ERROR:|fatal:|FATAL:|java\.io\.IOException|Build timed out|hudson\.plugins\.git\.GitException|Cannot rebase:|sh: line |dtrace: failed to compile script|Makefile:.+failed|make.*:.*(?:Error \d|write error)|warning: failed/; | ||
| const infrastructure = /Read-only file system|Device or resource busy|There is not enough space in the file system\./; |
Member
There was a problem hiding this comment.
Is it worth modifying ci_failure_parser such that these can be extracted from there rather than duplicated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplements #642 by @MoLow on current main, adding
ncu-ci resume <prid>with these additions:FAILUREorABORTED. Checks Jenkins’ resume action, allowing resumable aborted jobs.Includes command documentation, CLI exit-code tests, and regression fixtures captured with
ncu-ci walk.