Skip to content

test: make timeouts configurable - #437

Open
johnfinnerty-nz wants to merge 1 commit into
nodejs:mainfrom
johnfinnerty-nz:jftc/issue-407-test-timeouts
Open

test: make timeouts configurable#437
johnfinnerty-nz wants to merge 1 commit into
nodejs:mainfrom
johnfinnerty-nz:jftc/issue-407-test-timeouts

Conversation

@johnfinnerty-nz

Copy link
Copy Markdown

Summary

  • Add shared default timeouts for normal and long-running tests.
  • Allow CI and local runs to override them with TEST_TIMEOUT and TEST_TIMEOUT_LONG.
  • Replace the remaining hard-coded Tape timeouts with the shared values.

Closes #407

Testing

  • node --check on all six modified JavaScript files
  • Smoke check with TEST_TIMEOUT=1234 and TEST_TIMEOUT_LONG=5678
  • git diff --check

The repository linter could not run from this checkout path because its clang-format invocation does not quote paths containing spaces. The native LLDB test suite requires a built plugin.

Signed-off-by: John Finnerty <john@johnfinnerty.nz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply env variables to test timeouts consistently

1 participant