Repository navigation
Transfer mise trust to review worktree - #115
Merged
Merged
Conversation
Mise wraps Git so it refuses to read an untrusted mise.toml. The review checkout lives under the repository's Git directory, so mise does not inherit the source worktree's trust. Review checkout validation then fails at the first Git command, before Timber can reset the checkout. Copy the source worktree's trust state to the review checkout when the checkout has a mise config. Copy trust in both directions: trust the review checkout when the source is trusted, and untrust it when the source is untrusted, so a review of an untrusted worktree cannot reuse trust that an earlier review left behind. Mirror the trust again after the reset because paranoid mise ties trust to file contents, and a reset can change them. Change-Id: I6f7397be4b751a066ede302c2ace1415ac5edd28
The fake mise records the working directory that the shell reports, which is the physical path. macOS gives the temporary directory a symlinked path, so the recorded directories never matched the ones the test built: the trust state looked untrusted and the failure cases reported no error. Resolve the temporary directories in the test, as other review tests do. Change-Id: I0724689f4e2e77b7ee29eeb549518b4243527ca6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.