Repository navigation
Start the tap update when a release is published - #31
Merged
Merged
Conversation
A workflow run that GITHUB_TOKEN starts starts no further run, so a release that GITHUB_TOKEN publishes cannot start the tap update. The app token publishes the release instead, and it starts the tap update, which is how timber already publishes. The release.yaml files were otherwise the same as timber's, so the token step and the publish step now match it. Change-Id: Icda8d56d6948e9dd481cc5243d74ad209681c857
The push of a version tag fires before the release exists, so the workflow asked GitHub for a release that was not there yet and stopped with HTTP 404. constable v0.5.2, constable v0.6.0, git-bump v0.3.4, and roam v2.1.3 all left a stale formula that way. Listening for the published release removes the race, because the release and its assets exist by then. The tag branch of the resolve step goes with the trigger, so the step takes only the release tag or the dispatch input, as timber's step does. Change-Id: Ibbc6dfc5cb123f4475e7c4e86db1b5fa93794d43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.