Skip to content

Support nimble2 (with conflicts resolved) - #58

Open
perrydv wants to merge 24 commits into
masterfrom
support-nimble2-resolve-conflicts
Open

perrydv wants to merge 24 commits into
masterfrom
support-nimble2-resolve-conflicts

Conversation

@perrydv

@perrydv perrydv commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@paciorek Here is a PR with all the work to support nimble2 and with merge conflicts resolved.

perrydv added 24 commits June 22, 2026 14:04
@perrydv

perrydv commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

@paciorek This turns out to be a bit tricky. I fixed some problems like changing my code from using type to instrType in instrClass objects to catch up to your changes. Now I have test failures that don't obviously have to do with my contributions but I suspect come from some branch/merge glitching. Could you look at line 1616 of test-nimbleModel and line 455 of test-setupMargNodes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant