Repository navigation
Accept relayed Tailscale connectivity before deployment - #57
Merged
Merged
Conversation
The readiness probe received DERP pongs but required a direct path by default, so reachable nodes timed out before activation. Disable that requirement while keeping unreachable-peer retries and the existing timeout. Amp-Thread-ID: T-01a169a1-b58f-747d-8dfa-f3b5a4e3ed4b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The latest master workflow failed in Wait for the node, not in flake checks or
the Linux image build:
https://github.com/ngalaiko/computer/actions/runs/40002731857
Every probe received a pong through
DERP(fra), then exited withdirect connection not established. The defaulttailscale ping --until-direct=truemade the looprequire direct UDP connectivity and time out after 30 minutes, despite a reachable
peer. Activation never ran.
Fix
Set
--until-direct=falseon the existing one-probe readiness command. Accepteither direct or relayed reachability while retaining retries and the existing
timeout when the peer is genuinely unreachable. The SSH activation step still
enforces its own connection/authentication checks.
This changes only the reusable deployment workflow. No Dasha account, environment,
credentials, services, permissions, or runtime configuration is modified.
Verification
LocalAPI Unix socket: relay pong => exit 1, direct => exit 0, unreachable => exit 1.
direct => exit 0; unreachable => exit 1. Every scenario sent exactly one probe.
its default/direct-only failure matches the observed CI logs. Local CLI tests
use installed Tailscale v1.98.10; they simulate peer responses, not a live CI link.
nix flake check --all-systems --no-update-lock-filepassed.checks.x86_64-linux.formattingbuild passed; formatter made no changes.No manual deployment or CI rerun was triggered. Post-merge activation remains a
separate workflow outcome and is not claimed by these local checks.