Skip to content

feat(nextcloud): make probe paths configurable (#890) #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MishowHD wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(nextcloud): make probe paths configurable (#890) #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nextcloud/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: nextcloud
version: 9.4.1
version: 9.5.0
# renovate: image=docker.io/library/nextcloud
appVersion: 35.0.2
description: A file sharing server that puts the control and security of your own data back into your hands.
Expand Down
39 changes: 21 additions & 18 deletions charts/nextcloud/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,24 +533,27 @@ The nextcloud deployment includes a series of different probes you can use to de

| Parameter | Description | Default |
| ------------------------------------ | ------------------------------------------- | ------- |
| `livenessProbe.enabled` | Turn on and off liveness probe | `true` |
| `livenessProbe.initialDelaySeconds` | Delay before liveness probe is initiated | `10` |
| `livenessProbe.periodSeconds` | How often to perform the probe | `10` |
| `livenessProbe.timeoutSeconds` | When the probe times out | `5` |
| `livenessProbe.failureThreshold` | Minimum consecutive failures for the probe | `3` |
| `livenessProbe.successThreshold` | Minimum consecutive successes for the probe | `1` |
| `readinessProbe.enabled` | Turn on and off readiness probe | `true` |
| `readinessProbe.initialDelaySeconds` | Delay before readiness probe is initiated | `10` |
| `readinessProbe.periodSeconds` | How often to perform the probe | `10` |
| `readinessProbe.timeoutSeconds` | When the probe times out | `5` |
| `readinessProbe.failureThreshold` | Minimum consecutive failures for the probe | `3` |
| `readinessProbe.successThreshold` | Minimum consecutive successes for the probe | `1` |
| `startupProbe.enabled` | Turn on and off startup probe | `false` |
| `startupProbe.initialDelaySeconds` | Delay before readiness probe is initiated | `30` |
| `startupProbe.periodSeconds` | How often to perform the probe | `10` |
| `startupProbe.timeoutSeconds` | When the probe times out | `5` |
| `startupProbe.failureThreshold` | Minimum consecutive failures for the probe | `30` |
| `startupProbe.successThreshold` | Minimum consecutive successes for the probe | `1` |
| `livenessProbe.enabled` | Turn on and off liveness probe | `true` |
| `livenessProbe.path` | HTTP GET request path for liveness probe | `"/status.php"`|
| `livenessProbe.initialDelaySeconds` | Delay before liveness probe is initiated | `10` |
| `livenessProbe.periodSeconds` | How often to perform the probe | `10` |
| `livenessProbe.timeoutSeconds` | When the probe times out | `5` |
| `livenessProbe.failureThreshold` | Minimum consecutive failures for the probe | `3` |
| `livenessProbe.successThreshold` | Minimum consecutive successes for the probe | `1` |
| `readinessProbe.enabled` | Turn on and off readiness probe | `true` |
| `readinessProbe.path` | HTTP GET request path for readiness probe | `"/status.php"`|
| `readinessProbe.initialDelaySeconds` | Delay before readiness probe is initiated | `10` |
| `readinessProbe.periodSeconds` | How often to perform the probe | `10` |
| `readinessProbe.timeoutSeconds` | When the probe times out | `5` |
| `readinessProbe.failureThreshold` | Minimum consecutive failures for the probe | `3` |
| `readinessProbe.successThreshold` | Minimum consecutive successes for the probe | `1` |
| `startupProbe.enabled` | Turn on and off startup probe | `false` |
| `startupProbe.path` | HTTP GET request path for startup probe | `"/status.php"`|
| `startupProbe.initialDelaySeconds` | Delay before readiness probe is initiated | `30` |
| `startupProbe.periodSeconds` | How often to perform the probe | `10` |
| `startupProbe.timeoutSeconds` | When the probe times out | `5` |
| `startupProbe.failureThreshold` | Minimum consecutive failures for the probe | `30` |
| `startupProbe.successThreshold` | Minimum consecutive successes for the probe | `1` |

> [!Note]
> If you are getting errors on initialization (such as `Fatal error: require_once(): Failed opening required '/var/www/html/lib/versioncheck.php'`, but you can get other errors as well), a good first step is to try and enable the startupProbe and/or increase the `initialDelaySeconds` for the `livenessProbe` and `readinessProbe` to something much greater (consider using `120` seconds instead of `10`. This is an especially good idea if your cluster is running on older hardware, has a slow internet connection, or you're using a slower storage class, such as NFS that's running with older disks or a slow connection.
Expand Down
12 changes: 6 additions & 6 deletions charts/nextcloud/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ spec:
{{- if .enabled }}
livenessProbe:
httpGet:
path: /status.php
path: {{ .path | default "/status.php" }}
port: {{ $.Values.nextcloud.containerPort }}
httpHeaders:
- name: Host
Expand All @@ -110,7 +110,7 @@ spec:
{{- if .enabled }}
readinessProbe:
httpGet:
path: /status.php
path: {{ .path | default "/status.php" }}
port: {{ $.Values.nextcloud.containerPort }}
httpHeaders:
- name: Host
Expand All @@ -126,7 +126,7 @@ spec:
{{- if .enabled }}
startupProbe:
httpGet:
path: /status.php
path: {{ .path | default "/status.php" }}
port: {{ $.Values.nextcloud.containerPort }}
httpHeaders:
- name: Host
Expand Down Expand Up @@ -155,7 +155,7 @@ spec:
{{- if .enabled }}
livenessProbe:
httpGet:
path: /status.php
path: {{ .path | default "/status.php" }}
port: {{ $.Values.nextcloud.containerPort }}
httpHeaders:
- name: Host
Expand All @@ -171,7 +171,7 @@ spec:
{{- if .enabled }}
readinessProbe:
httpGet:
path: /status.php
path: {{ .path | default "/status.php" }}
port: {{ $.Values.nextcloud.containerPort }}
httpHeaders:
- name: Host
Expand All @@ -187,7 +187,7 @@ spec:
{{- if .enabled }}
startupProbe:
httpGet:
path: /status.php
path: {{ .path | default "/status.php" }}
port: {{ $.Values.nextcloud.containerPort }}
httpHeaders:
- name: Host
Expand Down
3 changes: 3 additions & 0 deletions charts/nextcloud/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,20 +844,23 @@ priorityClassName: ""
##
livenessProbe:
enabled: true
path: /status.php
initialDelaySeconds: 10
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 3
successThreshold: 1
readinessProbe:
enabled: true
path: /status.php
initialDelaySeconds: 10
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 3
successThreshold: 1
startupProbe:
enabled: false
path: /status.php
initialDelaySeconds: 30
periodSeconds: 10
timeoutSeconds: 5
Expand Down